openssl: fix mips64 abi detection when not cross compiling#165746
openssl: fix mips64 abi detection when not cross compiling#165746sternenseemann merged 1 commit intomasterfrom unknown repository
Conversation
|
Can you please amend to the commit with no changes to trigger CI? |
|
Done (I added an extra newline to the commit message). |
Acutally you don't need to change anything. Just amending without any changes generates a new hash and that is the only thing we need. |
SuperSandro2000
left a comment
There was a problem hiding this comment.
LGTM but I would like another person to take a look.
Oh right, because of the commit date. Thanks, I hadn't thought of that.
Cool; since you know the community better than I do could you suggest somebody to ping? The package lists @cstrahan as maintainer, so I guess that person is a good start. Is there some way for me to add people to the "reviews requested from" list? Or do I need superGithubPowers to do that? |
|
@ofborg build pkgsCross.mips64el-linux-gnuabi64.openssl pkgsCross.mips64el-linux-gnuabin32.openssl |
By the way, now that quite a bit of stuff in Obviously it is a separate decision whether or not to merge those additions to the |
ofborg parses commit messages and builds the attribute path mentioned in them before the colon if it has changed. Whether the attribute path has changed, is determined using Also ofborg doesn't continuously build stuff and notifies ppl about breakages, it exclusively tests PRs. If you haven't already, you should update |
Ah, that's exactly what I was looking for. Thanks! |
SuperSandro2000
left a comment
There was a problem hiding this comment.
I think we can squash merge this.
Squashed. |
When *not* cross-compiling, OpenSSL will not attempt to detect the host ABI. For mips64, the OpenSSL authors have chosen to assume that the n32 ABI is used. Since nixpkgs knows the correct ABI based on stdenv.hostPlatform, let's pass this information to OpenSSL explicitly. At the moment (bootstrappable) nixpkgs on mips64 can only be used with the n64 ABI due to the fact that boost-context (required by nix) does not support the n32 ABI. Without this commit the openssl expression can be cross-compiled to a mips64 host, but a mips64 host cannot self-compile the expression due to OpenSSL's incorrect assumption. #165746 (review)
When not cross-compiling, OpenSSL will not attempt to detect the
host ABI. For mips64, the OpenSSL authors have chosen to assume that
the n32 ABI is used.
Since nixpkgs knows the correct ABI based on stdenv.hostPlatform,
let's pass this information to OpenSSL explicitly.
At the moment (bootstrappable) nixpkgs on mips64 can only be used with
the n64 ABI due to the fact that boost-context (required by nix) does
not support the n32 ABI. Without this commit the openssl expression
can be cross-compiled to a mips64 host, but a mips64 host cannot
self-compile the expression due to OpenSSL's incorrect assumption.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes