Skip to content

fontforge: 20201107 -> 20220308#163439

Merged
erictapen merged 1 commit intoNixOS:stagingfrom
evils:fontforge
Mar 10, 2022
Merged

fontforge: 20201107 -> 20220308#163439
erictapen merged 1 commit intoNixOS:stagingfrom
evils:fontforge

Conversation

@evils
Copy link
Copy Markdown
Member

@evils evils commented Mar 9, 2022

Description of changes

https://github.com/fontforge/fontforge/releases/tag/20220308

Things done

updated the package
removed the upstreamed patch
edited the debian patch so it applies again
still seems required to get the extra binaries

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
    • not attempted, rebuild-amount.sh estimates 9633 packages affected, turns out a lot of stuff uses fonts...
  • Tested basic functionality of all binary files (usually in ./result/bin/)
    • not all, but the fontforge GUI seems to work
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar reviewed Mar 9, 2022
View reviewed changes
Comment thread pkgs/tools/misc/fontforge/default.nix Outdated
@ofborg ofborg bot requested a review from erictapen March 9, 2022 13:07
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 9, 2022
@evils evils force-pushed the fontforge branch 2 times, most recently from 948ec40 to 5c2d50b Compare March 9, 2022 13:20
@evils
fontforge: 20201107 -> 20220308
30d4974 
refactor the debian patch to apply
  still seems required to get the extra binaries

Co-authored-by: Jan Tojnar <jtojnar@gmail.com>
  (suggestion for partial applying the fetched patch)
jtojnar
jtojnar approved these changes Mar 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, did not test.

@evils
Copy link
Copy Markdown
Member Author

evils commented Mar 9, 2022

hmm
it emits
Core python package 'pkg_resources' not found: Cannot discover plugins

@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Mar 9, 2022

That is part of setuptools python package.

@jtojnar jtojnar mentioned this pull request Mar 9, 2022
Merged
erictapen
erictapen approved these changes Mar 10, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the python error: As python plugins were only introduced in this version, I guess it doesn't make anything worse than it was?

The remainder looks good to me, thanks a lot! Interested in adding yourself to maintainers of the package, @evils?

@erictapen erictapen merged commit 69da642 into NixOS:staging Mar 10, 2022
@evils
Copy link
Copy Markdown
Member Author

evils commented Mar 10, 2022

As python plugins were only introduced in this version, I guess it doesn't make anything worse

my guess also :)

Interested in adding yourself to maintainers of the package?

if i end up using it more, i just did this because i bumped it to the latest master a while ago because the packaged version occasionally crashed while giving it a go

@kevincox kevincox mentioned this pull request Apr 9, 2022
Closed
@AndrewKvalheim
Copy link
Copy Markdown
Member

AndrewKvalheim commented Nov 17, 2022

Core python package 'pkg_resources' not found: Cannot discover plugins

That is part of setuptools python package.

Should that be added? As is there’s a popup error message every time I open FontForge.

I’m inclined to just add it myself but it’s not clear to me how it should interact with withPython.

@UlyssesZh UlyssesZh mentioned this pull request Nov 14, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar approved these changes

@erictapen erictapen erictapen approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evils @jtojnar @AndrewKvalheim @erictapen