development/libraries/glibc: work around glibc tuple-parsing bug#163401
Conversation
Member
|
Can you paste the error? If we can fix it with a newer GNU config, we should do that instead. |
Author
It's this. Copy/paste of that comment:
Ah yes, I stumbled across it again. For posterity, to reproduce this issue, grab https://github.com/a-m-joseph/nixpkgs/tree/mips64el-support-first-steps-glibc-needs-to-parse-without-64-in-arch and then: ... the build of I'm doing a rebuild to get the lines preceding that in case they help. |
Author
full dump |
Author
|
The gcc error is: ... but that seems to be just a side effect of the unrecognized host tuple. |
Author
|
Attempting to add From |
Author
|
I'm a bit confused as to why ofborg says this needs 5001+ rebuilds. The added |
Glibc's configuration machinery cannot parse *-muslabi64, and fails with a very cryptic error message. This commit adds a --host=mips64el-linux-musl to extraConfigureFlags (so it comes after the --host= added by stdenv) in this case.
Author
Nevermind, I figured it out, have to set This should no longer cause any rebuilds whatsoever. In light of that, I have changed the base branch to |
Member
|
Also, I am confused why we are building glibc when we are trying to use musl! |
Member
|
Will take a look. |
Author
It was somewhere within ... I'm rebuilding with this patch reverted to find the exact reason. Yeah, I recall being surprised by that too. Note that you need to be cross-compiling a static binary. Although this sounds esoteric it is incredibly useful for producing the initial I also think it would be nice if Hydra built static |
Member
|
On the tip of master the only thing that didn't build for me was boost $ nix-build . -A pkgs.pkgsCross.mips64el-linux-gnuabi64.pkgsStatic.nix_2_4 --dry-run
these derivations will be built:
/nix/store/gjayd0z6742dp30ynpcqs757kkdin7a7-boost-static-mips64el-unknown-linux-muslabi64-1.77.0.drv
/nix/store/d7c5p1xin7x6b98pn78i0hgzakzqrd9l-nix-static-mips64el-unknown-linux-muslabi64-2.4.drvI think that means we can close this. |
14 tasks
Author
Yes. Tracking down exactly what was going on here was harder than I thought, so let me document it. For the record: this problem was introduced in the early revisions of my PR #161158. @Ericson2314 pointed out here that I was missing cases in the "convert this platform to a statically-linked platform" function. That function had no name at the time, and was copy-pasted into multiple different places; it has since been refactored as
Anyways, if this happens again, we know why. |
Author
@Ericson2314 by the way, that is fixed by #161162, which has had no objections since it was opened almost two months ago (just two minor formatting requests, both implemented)... |
9 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glibc's configuration machinery cannot parse *-muslabi64, and fails with a very cryptic error message. This commit adds a --host=mips64el-linux-musl to extraConfigureFlags (so it comes after the --host= added by stdenv) in this case.
This depends on #161158 and was split off from it as requested here
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes