Skip to content

libarchive: add some reverse dependencies to passthru.tests#159900

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
risicle:ris-libarchive-passthru-deps
Mar 27, 2022
Merged

libarchive: add some reverse dependencies to passthru.tests#159900
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
risicle:ris-libarchive-passthru-deps

Conversation

@risicle
Copy link
Copy Markdown
Contributor

@risicle risicle commented Feb 13, 2022

Motivation for this change

Packages that have a large reverse dependency set are hard to test because a full rebuild is infeasible. But on the other hand, it's tricky for reviewers to remember which reverse dependencies of a particular package are particularly important to ensure are working or are known to be particularly sensitive to changes in the depended package.

Therefore it makes sense to add a small selection of such packages to passthru.tests. Done here for libarchive.

See also #157872 for a similar approach being applied there.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 13, 2022
@SuperSandro2000 SuperSandro2000 merged commit 3812e3a into NixOS:master Mar 27, 2022
@risicle risicle mentioned this pull request Apr 2, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants