python3Packages.pillow: add some reverse dependencies to passthru.tests#159637
Merged
jonringer merged 1 commit intoNixOS:masterfrom Mar 7, 2022
Merged
python3Packages.pillow: add some reverse dependencies to passthru.tests#159637jonringer merged 1 commit intoNixOS:masterfrom
jonringer merged 1 commit intoNixOS:masterfrom
Conversation
picked for importance or sensitivity to pillow changes
This was referenced Feb 27, 2022
Member
|
is there a way to build a packages all passthru.tests, i couldn't find a way in the manual. |
Contributor
ofborg will do it by default |
Contributor
if your doing nixpkgs-review, |
jonringer
approved these changes
Mar 7, 2022
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Packages that have a large reverse dependency set are hard to test because a full rebuild is infeasible. But on the other hand, it's tricky for reviewers to remember which reverse dependencies of a particular package are particularly important to ensure are working or are known to be particularly sensitive to changes in the depended package.
Therefore it makes sense to add a small selection of such packages to
passthru.tests. Done here forpython3Packages.pillow.See also #157872 for a similar approach being applied there.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes