whitebophir: pin to nodejs-14_x to unbreak the build#155250
Closed
iblech wants to merge 1 commit into
Closed
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/node2nix-enotcached-when-using-callpackage-instead-of-import/17157/3 |
13 tasks
Contributor
Author
|
I'm closing this pull request because #158000 contains the commits from this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
On current nixpkgs-unstable and nixpkgs-master, whitebophir fails to build with "ENOTCACHED". Thanks to @ilkecan's insightful comment over at our Discourse, I was able to fix this issue by pinning to nodejs-14_x.
I also took the liberty of regenerating node-packages-generated.nix so we use newer versions of some dependencies. I'm the maintainer of this package.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes