Conversation
This was referenced Jan 14, 2022
3a33ea2 to
1953c25
Compare
1316adc to
1803472
Compare
6b2ce4c to
84217d1
Compare
13 tasks
13 tasks
f952180 to
e38a381
Compare
Member
|
Just did a force push after rebasing on staging. |
Contributor
Author
|
Thanks @mweinelt @dotlambda @fabaff for the help :) |
Member
|
@jonringer can you protect the branch so that it does not get deleted by accident? |
Contributor
|
Bisec says c84b744 |
Member
|
Fixed in #156305 |
Contributor
|
Bisect says c4f55d1 |
Contributor
Author
@SuperSandro2000 I cannot. I think you have to be admin. cc @domenkozar |
Member
|
Poked on matrix regarding branch protection. Was asked to rename the branch to |
Member
|
Does hydra mind? |
Member
|
Was already updated with that change in mind. The jobset is also now visible on the project page again. https://hydra.nixos.org/jobset/nixpkgs/python-unstable#tabs-configuration |
Contributor
|
This update has broken ❯ sudo nixos-rebuild switch [99/370]
building the system configuration...
warning: Git tree '/etc/nixos' is dirty
error: builder for '/nix/store/dhah3nazhf161y7rb77770khvmsxs8xh-kitty-0.24.2.drv' failed with exit code 2;
last 10 log lines:
> for result in self.emit(name, *args, allowed_exceptions=allowed_exceptions):
> File "/nix/store/13z9v2893iapkj12gk47q04w2197gysq-python3.9-sphinx-4.4.0/lib/python3.9/site-packages/sphinx/events.py", line 109, in emit
> raise ExtensionError(__("Handler %r for event %r threw an exception") %
> sphinx.errors.ExtensionError: Handler <function _html_page_context at 0x7ffff3218c10> for event 'html-page-context' threw an exception (exception: [Errno 2] No such file or directory: '/nix/store/pppq4jc77qw9qv4rqghqa32rjdm314hq-python3.9-furo-2022.1.2/lib/python3.9/s
ite-packages/furo/theme/furo/static/styles/furo.css')
>
> Extension error (furo):
> Handler <function _html_page_context at 0x7ffff3218c10> for event 'html-page-context' threw an exception (exception: [Errno 2] No such file or directory: '/nix/store/pppq4jc77qw9qv4rqghqa32rjdm314hq-python3.9-furo-2022.1.2/lib/python3.9/site-packages/furo/theme/furo/s
tatic/styles/furo.css')
> make[1]: *** [Makefile:24: html] Error 2
> make[1]: Leaving directory '/build/source/docs' |
Member
|
"This" is pretty vague for a package set update. The build of kitty might need to pin an older version of |
Contributor
|
Agreed, the fix needs to be made in kitty indeed. I'll discuss this with Kitty's maintainers. |
Contributor
|
This is not a kitty problem. furo is broken in nixpkgs because it depends on webpack to build some critical files, which is itself broken. |
13 tasks
Contributor
|
I created #159255, which fixes the problem. |
13 tasks
Member
|
the https://github.com/NixOS/nixpkgs/blob/master/pkgs/pkgs-lib/formats.nix Were there any tests to catch this? since pkgs.formats is used in quite a lot of modules and is a pain to fix without waiting for fixes to hit unstable |
Member
|
Python-unstable does not run NixOS tests, but maybe we should given that the test runner is also written in python. |
Member
|
Yeah, at the very least we should probably run some of the super core tests e.g pkgs-lib and those meta tests for the nixos testsuite itself (which I think are still in a PR but I cant find them right now) |
Contributor
Author
|
Solved by #159322 |
13 tasks
Contributor
This was referenced Feb 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It's that time again, not going to immediately trigger eval since the recent CVE master merges caused a lot of queue builds.
https://hydra.nixos.org/jobset/nixpkgs/python-unstable
Previous python-unstable: #149301
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes