Skip to content

pinentry: remove qt for x86_64-darwin due to build issues with qt#153113

Merged
veprbl merged 1 commit intoNixOS:masterfrom
Steven0351:pinentry-darwin
Jan 7, 2022
Merged

pinentry: remove qt for x86_64-darwin due to build issues with qt#153113
veprbl merged 1 commit intoNixOS:masterfrom
Steven0351:pinentry-darwin

Conversation

@Steven0351
Copy link
Copy Markdown
Member

@Steven0351 Steven0351 commented Jan 1, 2022

Motivation for this change

pinentry is broken on x86_64-darwin due to issues with the mkDerivation for libsForQt5

Things done

Changed logic for adding qt to enabledFlavors to only be for non-darwin platforms.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 1, 2022
@ofborg ofborg bot requested review from fpletz and ttuegel January 1, 2022 22:48
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 1, 2022
@veprbl
Copy link
Copy Markdown
Member

veprbl commented Jan 2, 2022

Seems like an LLVM bump regression:

In file included from pinentrydialog.cpp:30:
In file included from ./pinentrydialog.h:29:
In file included from /nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include/QtWidgets/QDialog:1:
In file included from /nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include/QtWidgets/qdialog.h:43:
In file included from /nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include/QtWidgets/qtwidgetsglobal.h:43:
In file included from /nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include/QtGui/qtguiglobal.h:43:
In file included from /nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include/QtCore/qglobal.h:45:
In file included from /nix/store/bb0bgspj580fghgzv9d9zvk5k9nn98d3-libcxx-11.1.0-dev/include/c++/v1/type_traits:417:
In file included from /nix/store/bb0bgspj580fghgzv9d9zvk5k9nn98d3-libcxx-11.1.0-dev/include/c++/v1/cstddef:37:
../version:1:1: error: expected unqualified-id
1.2.0-unknown
^

I've seen a similar issue pysathq/pysat#102 where #include <version> from inside libc++ is somehow picking up a header file from a build directory. Could be that some wrong -isystem is creeping into the build, but that would be a bug in our cc-wrapper.

cc @toonn

@veprbl veprbl merged commit a48caf2 into NixOS:master Jan 7, 2022
@toonn
Copy link
Copy Markdown
Contributor

toonn commented Jan 11, 2022

@veprbl, FWIW, AFAICT this is because many projects put the current directory, which is usually the root of the repo, in the include paths. And since these version files occur in many repos, it causes a problem.

IMO whoever figured this include was fine to put in the standard library, figured wrong. I haven't come up with a better fix than renaming the version files until upstream does so.

@veprbl
Copy link
Copy Markdown
Member

veprbl commented Jan 11, 2022

@toonn What you say makes sense. I wasn't expecting the libcxx system header to take priority.

Consider:

git checkout c1220ff9b0d8092564dee7ba083cfe2c572eed8e
nix-build -E '(import ./. {}).pinentry.overrideAttrs (prev: { NIX_DEBUG=1; })'

The last command will look like

Details ``` clang++ -DHAVE_CONFIG_H -I. -I.. -I/nix/store/3nx502wfycnndp0jbfgkzhigcpiqj0d8-libsecret-0.20.4-dev/include/libsecret-1 -I/nix/store/vrmqw6axbbrfwp1016p045rwb0kgv69r-glib-2.70.1-dev/include -I/nix/store/vrmqw6axbbrfwp1016p045rwb0kgv69r-glib-2.70.1-dev/include/glib-2.0 -I/nix/store/16zsfax6rm0vmzcb7xg9wfmimifjmaqh-glib-2.70.1/lib/glib-2.0/include -I/nix/store/7abb7igf2d9bvyl6zvwa16yg4d2kqhrz-libassuan-2.5.5-dev/include -I/nix/store/ksvxki83c1gczf993gayxrjapyrzdazw-libgpg-error-1.42-dev/include -I.. -I../secmem -I../pinentry -Wall -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I/nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include/QtWidgets -I/nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include -I/nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include/QtGui -I/nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include -I/nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include/QtCore -I/nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include -std=c++11 -g -O2 -c -o pinentrydialog.o pinentrydialog.cpp HARDENING: disabled flags: pie HARDENING: Is active (not completely disabled with "all" flag) HARDENING: enabling pic HARDENING: enabling format HARDENING: enabling stackprotector HARDENING: enabling fortify HARDENING: enabling strictoverflow extra flags before to /nix/store/bwkrfx42lh0ynxkd37kh4yfyklhxwlrm-clang-11.1.0/bin/clang++: -fPIC -Wformat -Wformat-security -Werror=format-security -fstack-protector-strong --param ssp-buffer-size=4 -O2 -D_FORTIFY_SOURCE=2 -fno-strict-overflow -mmacos-version-min=10.12 original flags to /nix/store/bwkrfx42lh0ynxkd37kh4yfyklhxwlrm-clang-11.1.0/bin/clang++: -DHAVE_CONFIG_H -I. -I.. -I/nix/store/3nx502wfycnndp0jbfgkzhigcpiqj0d8-libsecret-0.20.4-dev/include/libsecret-1 -I/nix/store/vrmqw6axbbrfwp1016p045rwb0kgv69r-glib-2.70.1-dev/include -I/nix/store/vrmqw6axbbrfwp1016p045rwb0kgv69r-glib-2.70.1-dev/include/glib-2.0 -I/nix/store/16zsfax6rm0vmzcb7xg9wfmimifjmaqh-glib-2.70.1/lib/glib-2.0/include -I/nix/store/7abb7igf2d9bvyl6zvwa16yg4d2kqhrz-libassuan-2.5.5-dev/include -I/nix/store/ksvxki83c1gczf993gayxrjapyrzdazw-libgpg-error-1.42-dev/include -I.. -I../secmem -I../pinentry -Wall -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I/nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include/QtWidgets -I/nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include -I/nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include/QtGui -I/nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include -I/nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include/QtCore -I/nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include -std=c++11 -g -O2 -c -o pinentrydialog.o pinentrydialog.cpp extra flags after to /nix/store/bwkrfx42lh0ynxkd37kh4yfyklhxwlrm-clang-11.1.0/bin/clang++: -target x86_64-apple-darwin -B/nix/store/5yn1kz42ii9xf872lwlz6mpglwrpwwgd-clang-11.1.0-lib/lib -arch x86_64 -resource-dir=/nix/store/a2sz5pfcilnp7hw9hhqipvs3rvq3s59v-clang-wrapper-11.1.0/resource-root -B/nix/store/a08bs0i5ngppxsby9ly3frzcc1zzr40b-Libsystem-1238.60.2/lib/ -idirafter /nix/store/a08bs0i5ngppxsby9ly3frzcc1zzr40b-Libsystem-1238.60.2/include -B/nix/store/a2sz5pfcilnp7hw9hhqipvs3rvq3s59v-clang-wrapper-11.1.0/bin/ -F/nix/store/0ayy2kw5lw511a94i3jprj364ijg3cac-apple-framework-CoreFoundation/Library/Frameworks -F/nix/store/0ayy2kw5lw511a94i3jprj364ijg3cac-apple-framework-CoreFoundation/Library/Frameworks -DQT_NO_DEBUG -frandom-seed=mfk7ksc7x8 -Wno-deprecated-declarations -F/System/Library/PrivateFrameworks -isystem /nix/store/30gh73scn0arcqyssm9pz3gm48vk87b5-gettext-0.21/include -isystem /nix/store/wvzzgjwnjl07z7127i52ssig1j1imax3-libtool-2.4.6/include -isystem /nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include -isystem /nix/store/3xxwd5jl1v16vh4xrmg0aj9hk8vy9kml-libxml2-2.9.12-dev/include -isystem /nix/store/ly30bl56qvd4q23pj4i4c5nd1y3599yg-zlib-1.2.11-dev/include -isystem /nix/store/pzj21smm39mnyd5yyz4bpi67njddrjg5-libiconv-50/include -isystem /nix/store/d7dbkwa6sb76p82sd2icwq7ginvf250d-libxslt-1.1.34-dev/include -isystem /nix/store/b4b6b3k6c0phgrbwsdyr5wfimzsfcvv4-openssl-1.1.1l-dev/include -isystem /nix/store/05mhagg4avcgka6azrxwdg0lj24x1lqr-sqlite-3.37.0-dev/include -isystem /nix/store/j56rd4cr0jw9zqwckjq7n3030ghp5gdd-harfbuzz-3.0.0-dev/include -isystem /nix/store/4jrisqrajc1a3yn43glm0wafsg8g4apw-graphite2-1.3.14/include -isystem /nix/store/rni34i43lwxqgqn7il74fdqygahiyg5r-icu4c-70.1-dev/include -isystem /nix/store/y3d8kxarcw9krwvlvhnjkzjb3f8ngqw1-libjpeg-turbo-2.1.0-dev/include -isystem /nix/store/gc7p4kbwl26bbk49nmnjrjd4azdnrzqd-libpng-apng-1.6.37-dev/include -isystem /nix/store/snpli262654nyibbiscabj2iqjn2raay-pcre2-10.37-dev/include -iframework /nix/store/0xsbzisfl7aw8wjivkfmyrpn584qqwlw-apple-framework-AGL/Library/Frameworks -iframework /nix/store/f5sv81wr7kp62gjqjhgdddvj3zi3pgaq-apple-framework-Carbon/Library/Frameworks -iframework /nix/store/qwk3hvl9vxybprmvv7qcx4wdspgwfjlf-apple-framework-ApplicationServices/Library/Frameworks -iframework /nix/store/xngzknwwglkz3870mlpbl3hxmpcl3gbg-apple-framework-CoreGraphics/Library/Frameworks -iframework /nix/store/iii3fgmbyggv87ppmdk23ywdry1wj5fq-apple-framework-Accelerate/Library/Frameworks -iframework /nix/store/apkfz1l6fir87vfibv1ys99nhz5zxa9x-apple-framework-CoreWLAN/Library/Frameworks -iframework /nix/store/4l2dpqhs9kj4vdhzadjv2nx9760q21wm-apple-framework-SecurityFoundation/Library/Frameworks -iframework /nix/store/22i3r2ai68p7qy6vf0545xwk1yq0r68q-apple-framework-IOBluetooth/Library/Frameworks -iframework /nix/store/sqd2pv9ix1jlh91fqgmz5531qi2cji9b-apple-framework-CoreBluetooth/Library/Frameworks -iframework /nix/store/zw1wg23rzl3wz9akgad0frxcjwvb57wr-apple-framework-IOKit/Library/Frameworks -iframework /nix/store/s3md44lif42xn1bsp029x4fipw9hv53g-apple-framework-IOSurface/Library/Frameworks -isystem /nix/store/mr4cyfldgmrbj0anylqm4l2x3jmcasbg-apple-lib-xpc/include -iframework /nix/store/907j82apg3mjpl9i66cxvigy9gf4w2pq-apple-framework-SystemConfiguration/Library/Frameworks -iframework /nix/store/jc5sdqi0j0nyv9mqm2v4hzv4rgpdvz4v-apple-framework-Security/Library/Frameworks -iframework /nix/store/jpipb9frnh7msd4vxqmbhd913ymqhjz8-apple-framework-CoreServices/Library/Frameworks -iframework /nix/store/7r3lr680b72bjxh3zibdw8rqndqzhzcn-apple-framework-CFNetwork/Library/Frameworks -iframework /nix/store/i67bzqwvlapsbd0fch5ssmflx8w3h29x-apple-framework-CoreAudio/Library/Frameworks -iframework /nix/store/qb86vmm5hiqbh5wkmwfv52lv6l3y3fh3-apple-framework-CoreData/Library/Frameworks -iframework /nix/store/0ayy2kw5lw511a94i3jprj364ijg3cac-apple-framework-CoreFoundation/Library/Frameworks -iframework /nix/store/0da5g4rf3ndxw8dl0scrr9wrlrah1f15-apple-framework-DiskArbitration/Library/Frameworks -iframework /nix/store/1fs3rw7ih4rpa6q049mmx0w0dv2afg0m-apple-framework-NetFS/Library/Frameworks -iframework /nix/store/rqrzpysjy3h7d4k6ikn00f0m6hvwv0v5-apple-framework-OpenDirectory/Library/Frameworks -iframework /nix/store/ssjdy9kc5h0niz72cjmyiv4937rsw8cz-apple-framework-ServiceManagement/Library/Frameworks -iframework /nix/store/vaahcnm1b57l5vda4y6wbqy85r6q9lkd-apple-framework-CoreText/Library/Frameworks -iframework /nix/store/1mq510psflrm4ygldfvgxnv8f19mg4j0-apple-framework-ImageIO/Library/Frameworks -iframework /nix/store/1pynnysy3fz11cggfi5y75hm3s4sixgj-apple-framework-Foundation/Library/Frameworks -isystem /nix/store/mchslrkj659n4s58xp3crnxd745am3a4-objc4-709.1/include -iframework /nix/store/r9v0hyxwq9gwx3zs6c21w0l8l1wshlml-apple-framework-QuartzCore/Library/Frameworks -iframework /nix/store/0flabi2kw9l69ml55n18ym71xlpl9lvf-apple-framework-CoreImage/Library/Frameworks -iframework /nix/store/v2v0mzkyl041ayrwihd718xxfy5g13dm-apple-framework-CoreVideo/Library/Frameworks -iframework /nix/store/vg7w9afix2mrp01drhzs26056zfnng4y-apple-framework-OpenGL/Library/Frameworks -iframework /nix/store/wfvcbsm2r32hryvpzd9s2arpilm1b686-apple-framework-Metal/Library/Frameworks -iframework /nix/store/4rw0i4v4rdjdhng2paz9kpn4nknscxhf-apple-framework-OpenCL/Library/Frameworks -iframework /nix/store/5lsfhy6ibpqhkxf9v6yz80fcprc2134l-apple-framework-AppKit/Library/Frameworks -iframework /nix/store/zd927na30z59rq8knbc0sw5nrns2snnn-apple-framework-AudioToolbox/Library/Frameworks -iframework /nix/store/s1cgv2ks0x6mbdas6m4kkbbjddh8bd3g-apple-framework-CoreMIDI/Library/Frameworks -iframework /nix/store/z83rs5ypf0nn6br6w5kj5f9mc1k45y99-apple-framework-AudioUnit/Library/Frameworks -iframework /nix/store/pvrffshjwi5c134zlbam3jhramw6is91-apple-framework-UIFoundation/Library/Frameworks -iframework /nix/store/xrni8kvhkxpkm647h31kwfy1arp0i68x-apple-framework-Cocoa/Library/Frameworks -iframework /nix/store/85fcfr02pplgqr1dm3yq47mv9vfcqs44-apple-framework-CoreLocation/Library/Frameworks -isystem /nix/store/z1rcfxjnd0lri5j29whk41laciaj0jqi-apple-framework-MetalKit/include -iframework /nix/store/z1rcfxjnd0lri5j29whk41laciaj0jqi-apple-framework-MetalKit/Library/Frameworks -iframework /nix/store/3m6zf6axf66bqglkzmdbi1s4xa8kmn4v-apple-framework-ModelIO/Library/Frameworks -isystem /nix/store/bb0bgspj580fghgzv9d9zvk5k9nn98d3-libcxx-11.1.0-dev/include -isystem /nix/store/j1nfjz1wc9mp9a5zmq18iy31rm9zy3i1-libcxxabi-11.1.0-dev/include -isystem /nix/store/mj171ss18sax7bmlfldraqi9gfqgl595-compiler-rt-libc-11.1.0-dev/include -isystem /nix/store/ksvxki83c1gczf993gayxrjapyrzdazw-libgpg-error-1.42-dev/include -isystem /nix/store/7abb7igf2d9bvyl6zvwa16yg4d2kqhrz-libassuan-2.5.5-dev/include -isystem /nix/store/3nx502wfycnndp0jbfgkzhigcpiqj0d8-libsecret-0.20.4-dev/include -isystem /nix/store/vrmqw6axbbrfwp1016p045rwb0kgv69r-glib-2.70.1-dev/include -isystem /nix/store/0mw7v8pmzv6ziqfxln0p1wprwfxxrcp1-libffi-3.4.2-dev/include -isystem /nix/store/zywyb08b10888zsrnwkd51hii6lk2rr3-ncurses-6.2-dev/include -isystem /nix/store/jzxqq996aq6rya6mn1620j525qz441zz-gtk+-2.24.33-dev/include -isystem /nix/store/nrvp3dplcsz7p8s35xcl7zgxj4grwjrd-cairo-1.16.0-dev/include -isystem /nix/store/ig67hy0j77y8sg4m4g6qxm03a77kkjv5-fontconfig-2.13.94-dev/include -isystem /nix/store/81z8ljqm35dqr1s1m1ap1ipm5a1nag7l-freetype-2.11.0-dev/include -isystem /nix/store/x1pja1y70gcvx7lay5s03ciixfxi0bwa-bzip2-1.0.6.0.2-dev/include -isystem /nix/store/hq0kpc03021xbrz6zj36v8b5aapzvmy9-expat-2.4.1-dev/include -isystem /nix/store/rxwxn8v4a1vhq2wl16yjpn5p619kn173-pixman-0.38.4/include -isystem /nix/store/qzqkxsnhy6fb5pm1n1dixw3qm04jfyif-pango-1.48.10-dev/include -isystem /nix/store/8pbpm33ka0q5v36jvx1yikrh7i8pwyqz-harfbuzz-3.0.0-dev/include -isystem /nix/store/6ixl0bb02cdpwwgwc32vizriqgyc93n5-gdk-pixbuf-2.42.6-dev/include -isystem /nix/store/7pq3w9xixmj8yx1wik6ari9y9fa14sqf-libtiff-4.3.0-dev/include -isystem /nix/store/1mpyxl4jcciv035ga4907wba09ifivkk-xz-5.2.5-dev/include -isystem /nix/store/ph9g3kh0l0c5gxlycwh9rn5wi80w0xpq-atk-2.36.0-dev/include -isystem /nix/store/w01p6hbaibha2swdlqlipfp5hg7909ld-libXrandr-1.5.2-dev/include -isystem /nix/store/0a4p7c85rw3n550wsklm8kmj24f23sgw-libXrender-0.9.10-dev/include -isystem /nix/store/69dwbpw8q34q2sf1ymhyg7p3j4ad2mjl-xorgproto-2021.5/include -isystem /nix/store/6c8xngzksy4486ddmsi9p2nj4y761c6g-libX11-1.7.2-dev/include -isystem /nix/store/q0snkzvz1ifpz3x56h6qxa44l5c2larv-libxcb-1.14-dev/include -isystem /nix/store/7hxwss2dbs89bhsyg8dfaf9xi14whwc8-libXcomposite-0.4.5-dev/include -isystem /nix/store/c51qflczsjxzks4mm11cfwgfahssdknr-libXfixes-6.0.0-dev/include -isystem /nix/store/784jbdj96dl7hvk5fbljgqhixacwnzip-libXi-1.8-dev/include -isystem /nix/store/8ma36rdl09s3j753gj6zf98gz6v45778-libXcursor-1.2.0-dev/include -isystem /nix/store/4hwslvgh1sl8x7yg9jcvah3dfnf3g3hy-libXt-1.2.1-dev/include -isystem /nix/store/aijcym0pp7vzd3m3pfdb8vkfwix5zqlf-libSM-1.2.3-dev/include -isystem /nix/store/j0gq8vndb7vwf3b7nrww996bcrv1rclm-libICE-1.0.10-dev/include -isystem /nix/store/9whm9a18jhcms8xdvwqwlg4vpdxzd29n-libXft-2.3.4-dev/include -isystem /nix/store/qspyi80k52y5sazfzdrc5c9v3b8dkpmb-libXext-1.3.4-dev/include -isystem /nix/store/n6fxc8x5czn8vkv678dpl3c0lij7016i-libXau-1.0.9-dev/include -isystem /nix/store/5vi54n9b21j0hm23mbqfnabr14f49psh-libXdamage-1.1.5-dev/include -iframework /nix/store/82d092jfk2sckailcp5hpb29xsxhk4h2-swift-corefoundation/Library/Frameworks -isystem /nix/store/30gh73scn0arcqyssm9pz3gm48vk87b5-gettext-0.21/include -isystem /nix/store/wvzzgjwnjl07z7127i52ssig1j1imax3-libtool-2.4.6/include -isystem /nix/store/yywbwgbd1k3ld4lxwqhb3ib121zwyhxf-qtbase-5.12.10-dev/include -isystem /nix/store/3xxwd5jl1v16vh4xrmg0aj9hk8vy9kml-libxml2-2.9.12-dev/include -isystem /nix/store/ly30bl56qvd4q23pj4i4c5nd1y3599yg-zlib-1.2.11-dev/include -isystem /nix/store/pzj21smm39mnyd5yyz4bpi67njddrjg5-libiconv-50/include -isystem /nix/store/d7dbkwa6sb76p82sd2icwq7ginvf250d-libxslt-1.1.34-dev/include -isystem /nix/store/b4b6b3k6c0phgrbwsdyr5wfimzsfcvv4-openssl-1.1.1l-dev/include -isystem /nix/store/05mhagg4avcgka6azrxwdg0lj24x1lqr-sqlite-3.37.0-dev/include -isystem /nix/store/j56rd4cr0jw9zqwckjq7n3030ghp5gdd-harfbuzz-3.0.0-dev/include -isystem /nix/store/4jrisqrajc1a3yn43glm0wafsg8g4apw-graphite2-1.3.14/include -isystem /nix/store/rni34i43lwxqgqn7il74fdqygahiyg5r-icu4c-70.1-dev/include -isystem /nix/store/y3d8kxarcw9krwvlvhnjkzjb3f8ngqw1-libjpeg-turbo-2.1.0-dev/include -isystem /nix/store/gc7p4kbwl26bbk49nmnjrjd4azdnrzqd-libpng-apng-1.6.37-dev/include -isystem /nix/store/snpli262654nyibbiscabj2iqjn2raay-pcre2-10.37-dev/include -iframework /nix/store/0xsbzisfl7aw8wjivkfmyrpn584qqwlw-apple-framework-AGL/Library/Frameworks -iframework /nix/store/f5sv81wr7kp62gjqjhgdddvj3zi3pgaq-apple-framework-Carbon/Library/Frameworks -iframework /nix/store/qwk3hvl9vxybprmvv7qcx4wdspgwfjlf-apple-framework-ApplicationServices/Library/Frameworks -iframework /nix/store/xngzknwwglkz3870mlpbl3hxmpcl3gbg-apple-framework-CoreGraphics/Library/Frameworks -iframework /nix/store/iii3fgmbyggv87ppmdk23ywdry1wj5fq-apple-framework-Accelerate/Library/Frameworks -iframework /nix/store/apkfz1l6fir87vfibv1ys99nhz5zxa9x-apple-framework-CoreWLAN/Library/Frameworks -iframework /nix/store/4l2dpqhs9kj4vdhzadjv2nx9760q21wm-apple-framework-SecurityFoundation/Library/Frameworks -iframework /nix/store/22i3r2ai68p7qy6vf0545xwk1yq0r68q-apple-framework-IOBluetooth/Library/Frameworks -iframework /nix/store/sqd2pv9ix1jlh91fqgmz5531qi2cji9b-apple-framework-CoreBluetooth/Library/Frameworks -iframework /nix/store/zw1wg23rzl3wz9akgad0frxcjwvb57wr-apple-framework-IOKit/Library/Frameworks -iframework /nix/store/s3md44lif42xn1bsp029x4fipw9hv53g-apple-framework-IOSurface/Library/Frameworks -isystem /nix/store/mr4cyfldgmrbj0anylqm4l2x3jmcasbg-apple-lib-xpc/include -iframework /nix/store/907j82apg3mjpl9i66cxvigy9gf4w2pq-apple-framework-SystemConfiguration/Library/Frameworks -iframework /nix/store/jc5sdqi0j0nyv9mqm2v4hzv4rgpdvz4v-apple-framework-Security/Library/Frameworks -iframework /nix/store/jpipb9frnh7msd4vxqmbhd913ymqhjz8-apple-framework-CoreServices/Library/Frameworks -iframework /nix/store/7r3lr680b72bjxh3zibdw8rqndqzhzcn-apple-framework-CFNetwork/Library/Frameworks -iframework /nix/store/i67bzqwvlapsbd0fch5ssmflx8w3h29x-apple-framework-CoreAudio/Library/Frameworks -iframework /nix/store/qb86vmm5hiqbh5wkmwfv52lv6l3y3fh3-apple-framework-CoreData/Library/Frameworks -iframework /nix/store/0ayy2kw5lw511a94i3jprj364ijg3cac-apple-framework-CoreFoundation/Library/Frameworks -iframework /nix/store/0da5g4rf3ndxw8dl0scrr9wrlrah1f15-apple-framework-DiskArbitration/Library/Frameworks -iframework /nix/store/1fs3rw7ih4rpa6q049mmx0w0dv2afg0m-apple-framework-NetFS/Library/Frameworks -iframework /nix/store/rqrzpysjy3h7d4k6ikn00f0m6hvwv0v5-apple-framework-OpenDirectory/Library/Frameworks -iframework /nix/store/ssjdy9kc5h0niz72cjmyiv4937rsw8cz-apple-framework-ServiceManagement/Library/Frameworks -iframework /nix/store/vaahcnm1b57l5vda4y6wbqy85r6q9lkd-apple-framework-CoreText/Library/Frameworks -iframework /nix/store/1mq510psflrm4ygldfvgxnv8f19mg4j0-apple-framework-ImageIO/Library/Frameworks -iframework /nix/store/1pynnysy3fz11cggfi5y75hm3s4sixgj-apple-framework-Foundation/Library/Frameworks -isystem /nix/store/mchslrkj659n4s58xp3crnxd745am3a4-objc4-709.1/include -iframework /nix/store/r9v0hyxwq9gwx3zs6c21w0l8l1wshlml-apple-framework-QuartzCore/Library/Frameworks -iframework /nix/store/0flabi2kw9l69ml55n18ym71xlpl9lvf-apple-framework-CoreImage/Library/Frameworks -iframework /nix/store/v2v0mzkyl041ayrwihd718xxfy5g13dm-apple-framework-CoreVideo/Library/Frameworks -iframework /nix/store/vg7w9afix2mrp01drhzs26056zfnng4y-apple-framework-OpenGL/Library/Frameworks -iframework /nix/store/wfvcbsm2r32hryvpzd9s2arpilm1b686-apple-framework-Metal/Library/Frameworks -iframework /nix/store/4rw0i4v4rdjdhng2paz9kpn4nknscxhf-apple-framework-OpenCL/Library/Frameworks -iframework /nix/store/5lsfhy6ibpqhkxf9v6yz80fcprc2134l-apple-framework-AppKit/Library/Frameworks -iframework /nix/store/zd927na30z59rq8knbc0sw5nrns2snnn-apple-framework-AudioToolbox/Library/Frameworks -iframework /nix/store/s1cgv2ks0x6mbdas6m4kkbbjddh8bd3g-apple-framework-CoreMIDI/Library/Frameworks -iframework /nix/store/z83rs5ypf0nn6br6w5kj5f9mc1k45y99-apple-framework-AudioUnit/Library/Frameworks -iframework /nix/store/pvrffshjwi5c134zlbam3jhramw6is91-apple-framework-UIFoundation/Library/Frameworks -iframework /nix/store/xrni8kvhkxpkm647h31kwfy1arp0i68x-apple-framework-Cocoa/Library/Frameworks -iframework /nix/store/85fcfr02pplgqr1dm3yq47mv9vfcqs44-apple-framework-CoreLocation/Library/Frameworks -isystem /nix/store/z1rcfxjnd0lri5j29whk41laciaj0jqi-apple-framework-MetalKit/include -iframework /nix/store/z1rcfxjnd0lri5j29whk41laciaj0jqi-apple-framework-MetalKit/Library/Frameworks -iframework /nix/store/3m6zf6axf66bqglkzmdbi1s4xa8kmn4v-apple-framework-ModelIO/Library/Frameworks -isystem /nix/store/bb0bgspj580fghgzv9d9zvk5k9nn98d3-libcxx-11.1.0-dev/include -isystem /nix/store/j1nfjz1wc9mp9a5zmq18iy31rm9zy3i1-libcxxabi-11.1.0-dev/include -isystem /nix/store/mj171ss18sax7bmlfldraqi9gfqgl595-compiler-rt-libc-11.1.0-dev/include -isystem /nix/store/ksvxki83c1gczf993gayxrjapyrzdazw-libgpg-error-1.42-dev/include -isystem /nix/store/7abb7igf2d9bvyl6zvwa16yg4d2kqhrz-libassuan-2.5.5-dev/include -isystem /nix/store/3nx502wfycnndp0jbfgkzhigcpiqj0d8-libsecret-0.20.4-dev/include -isystem /nix/store/vrmqw6axbbrfwp1016p045rwb0kgv69r-glib-2.70.1-dev/include -isystem /nix/store/0mw7v8pmzv6ziqfxln0p1wprwfxxrcp1-libffi-3.4.2-dev/include -isystem /nix/store/zywyb08b10888zsrnwkd51hii6lk2rr3-ncurses-6.2-dev/include -isystem /nix/store/jzxqq996aq6rya6mn1620j525qz441zz-gtk+-2.24.33-dev/include -isystem /nix/store/nrvp3dplcsz7p8s35xcl7zgxj4grwjrd-cairo-1.16.0-dev/include -isystem /nix/store/ig67hy0j77y8sg4m4g6qxm03a77kkjv5-fontconfig-2.13.94-dev/include -isystem /nix/store/81z8ljqm35dqr1s1m1ap1ipm5a1nag7l-freetype-2.11.0-dev/include -isystem /nix/store/x1pja1y70gcvx7lay5s03ciixfxi0bwa-bzip2-1.0.6.0.2-dev/include -isystem /nix/store/hq0kpc03021xbrz6zj36v8b5aapzvmy9-expat-2.4.1-dev/include -isystem /nix/store/rxwxn8v4a1vhq2wl16yjpn5p619kn173-pixman-0.38.4/include -isystem /nix/store/qzqkxsnhy6fb5pm1n1dixw3qm04jfyif-pango-1.48.10-dev/include -isystem /nix/store/8pbpm33ka0q5v36jvx1yikrh7i8pwyqz-harfbuzz-3.0.0-dev/include -isystem /nix/store/6ixl0bb02cdpwwgwc32vizriqgyc93n5-gdk-pixbuf-2.42.6-dev/include -isystem /nix/store/7pq3w9xixmj8yx1wik6ari9y9fa14sqf-libtiff-4.3.0-dev/include -isystem /nix/store/1mpyxl4jcciv035ga4907wba09ifivkk-xz-5.2.5-dev/include -isystem /nix/store/ph9g3kh0l0c5gxlycwh9rn5wi80w0xpq-atk-2.36.0-dev/include -isystem /nix/store/w01p6hbaibha2swdlqlipfp5hg7909ld-libXrandr-1.5.2-dev/include -isystem /nix/store/0a4p7c85rw3n550wsklm8kmj24f23sgw-libXrender-0.9.10-dev/include -isystem /nix/store/69dwbpw8q34q2sf1ymhyg7p3j4ad2mjl-xorgproto-2021.5/include -isystem /nix/store/6c8xngzksy4486ddmsi9p2nj4y761c6g-libX11-1.7.2-dev/include -isystem /nix/store/q0snkzvz1ifpz3x56h6qxa44l5c2larv-libxcb-1.14-dev/include -isystem /nix/store/7hxwss2dbs89bhsyg8dfaf9xi14whwc8-libXcomposite-0.4.5-dev/include -isystem /nix/store/c51qflczsjxzks4mm11cfwgfahssdknr-libXfixes-6.0.0-dev/include -isystem /nix/store/784jbdj96dl7hvk5fbljgqhixacwnzip-libXi-1.8-dev/include -isystem /nix/store/8ma36rdl09s3j753gj6zf98gz6v45778-libXcursor-1.2.0-dev/include -isystem /nix/store/4hwslvgh1sl8x7yg9jcvah3dfnf3g3hy-libXt-1.2.1-dev/include -isystem /nix/store/aijcym0pp7vzd3m3pfdb8vkfwix5zqlf-libSM-1.2.3-dev/include -isystem /nix/store/j0gq8vndb7vwf3b7nrww996bcrv1rclm-libICE-1.0.10-dev/include -isystem /nix/store/9whm9a18jhcms8xdvwqwlg4vpdxzd29n-libXft-2.3.4-dev/include -isystem /nix/store/qspyi80k52y5sazfzdrc5c9v3b8dkpmb-libXext-1.3.4-dev/include -isystem /nix/store/n6fxc8x5czn8vkv678dpl3c0lij7016i-libXau-1.0.9-dev/include -isystem /nix/store/5vi54n9b21j0hm23mbqfnabr14f49psh-libXdamage-1.1.5-dev/include -iframework /nix/store/82d092jfk2sckailcp5hpb29xsxhk4h2-swift-corefoundation/Library/Frameworks -isystem /nix/store/bb0bgspj580fghgzv9d9zvk5k9nn98d3-libcxx-11.1.0-dev/include/c++/v1 ```

So, according to https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html, the -I. would take precedence over -isystem /nix/store/bb0bgspj580fghgzv9d9zvk5k9nn98d3-libcxx-11.1.0-dev/include/c++/v1.

@veprbl
Copy link
Copy Markdown
Member

veprbl commented Jan 11, 2022

IMO whoever figured this include was fine to put in the standard library, figured wrong. I haven't come up with a better fix than renaming the version files until upstream does so.

What if we patch the libc++ itself to use full paths in the include directives? There are a few locations like

sed -ne '37p' /nix/store/bb0bgspj580fghgzv9d9zvk5k9nn98d3-libcxx-11.1.0-dev/include/c++/v1/cstddef
#include <version>

@toonn
Copy link
Copy Markdown
Contributor

toonn commented Jan 11, 2022

No no, I'm saying the current directory indeed has precedence and therefore the stdlib tries to include a file containing just a version number.

That might be a good temporary workaround. Does mean the core of these issues will have one less motivating factor to get fixed but I guess that's upstream's responsibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants