Skip to content

linux-pam: don't create dangling symlink during build#153104

Merged
vcunat merged 1 commit intoNixOS:stagingfrom
winterqt:linux-pam-dangling-symlink
Jan 9, 2022
Merged

linux-pam: don't create dangling symlink during build#153104
vcunat merged 1 commit intoNixOS:stagingfrom
winterqt:linux-pam-dangling-symlink

Conversation

@winterqt
Copy link
Copy Markdown
Member

@winterqt winterqt commented Jan 1, 2022

Motivation for this change

#152844

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 1, 2022
@vcunat vcunat linked an issue Jan 1, 2022 that may be closed by this pull request
linux-pam creates dangling symlinks to chkpwd #152844
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 2, 2022
@vcunat vcunat merged commit c3805ba into NixOS:staging Jan 9, 2022
@andrevmatos
Copy link
Copy Markdown
Member

andrevmatos commented Jan 26, 2022 •
edited
Loading

I think this may have broken KDE Plasma's Lockscreen. Trying to unlock, even being 100% sure the password is correct, gives wrong password, and in the journal:

unix_chkpwd[46155]: check pass; user unknown
unix_chkpwd[46156]: check pass; user unknown
unix_chkpwd[46156]: password check failed for user (andre)
kcheckpass[46154]: pam_unix(kde:auth): authentication failure; logname= uid=1000 euid=1000 tty= ruser= rhost=  user=andre
kcheckpass[46154]: Authentication failure for andre (invoked by uid 1000)

For now, I need to log in another tty, and type loginctl unlock-sessions

@lovesegfault
Copy link
Copy Markdown
Member

lovesegfault commented Jan 27, 2022

Yeah, I think this broken swaylock too

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Jan 27, 2022

Hmm, so I expect they're trying to use ${pam}/bin/unix_chkpwd directly instead of the wrapper from $PATH. Maybe it will be best to revert back to using that symlink hack?

@vcunat vcunat mentioned this pull request Jan 27, 2022
Merged
13 tasks
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Jan 27, 2022

Or perhaps approach like PR #156974

@winterqt winterqt deleted the linux-pam-dangling-symlink branch January 29, 2022 01:17
This was referenced Feb 3, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

linux-pam creates dangling symlinks to chkpwd

4 participants

@winterqt @andrevmatos @lovesegfault @vcunat