Skip to content

spice-gtk: 0.37 -> 0.39#152044

Closed
tadeokondrak wants to merge 1 commit intoNixOS:masterfrom
tadeokondrak:spice-gtk-update-0.39
Closed

spice-gtk: 0.37 -> 0.39#152044
tadeokondrak wants to merge 1 commit intoNixOS:masterfrom
tadeokondrak:spice-gtk-update-0.39

Conversation

@tadeokondrak
Copy link
Copy Markdown
Contributor

@tadeokondrak tadeokondrak commented Dec 24, 2021 •
edited
Loading

Motivation for this change

This update fixes issues I've had with display scaling.i

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from xeji December 24, 2021 22:38
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 24, 2021
@Tungsten842
Copy link
Copy Markdown
Member

Tungsten842 commented Dec 25, 2021

Result of nixpkgs-review pr 152044 run on x86_64-linux 1

6 packages built:
  • gnome.gnome-boxes
  • remmina
  • spice-gtk
  • virt-manager
  • virt-manager-qt
  • virt-viewer

@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Jan 26, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/701

@jtojnar jtojnar mentioned this pull request Jan 26, 2022
Closed
jtojnar
jtojnar requested changes Jan 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at changelog,

@tadeokondrak tadeokondrak force-pushed the spice-gtk-update-0.39 branch from 73fa3ea to 3896ee6 Compare January 27, 2022 19:50
@tadeokondrak tadeokondrak requested a review from jtojnar January 27, 2022 19:51
@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Jan 27, 2022 •
edited
Loading

Looks like pulse was not the only removed option:

meson.build:4:0: ERROR: Unknown options: "celt051"

https://gitlab.freedesktop.org/spice/spice-gtk/-/commit/6e9d8cfc02873ec970f6f36be0f5d2705850d021

@tadeokondrak tadeokondrak force-pushed the spice-gtk-update-0.39 branch from 3896ee6 to 9b036ab Compare January 27, 2022 20:33
@tadeokondrak tadeokondrak force-pushed the spice-gtk-update-0.39 branch from 9b036ab to 54fd365 Compare January 27, 2022 20:36
@tadeokondrak
Copy link
Copy Markdown
Contributor Author

tadeokondrak commented Jan 27, 2022

Looks like pulse was not the only removed option:

Huh, I didn't see this because it only showed up as a warning. I fixed some other issues:
usbids is needed for its usb.ids file, but usbids doesn't have it (nor a pkg-config file) in nixpkgs.
I use the hwdata package instead.

asciidoc is used in the spice-common subproject which is only used for documentation that doesn't make it to this package, removed

@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Jan 27, 2022

(We have just merged new Meson version that is more strict.)

@andersk andersk mentioned this pull request Feb 11, 2022
Merged
13 tasks
@tadeokondrak
Copy link
Copy Markdown
Contributor Author

tadeokondrak commented Feb 11, 2022

Superseded by #159340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xeji xeji Awaiting requested review from xeji

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tadeokondrak @Tungsten842 @nixos-discourse @jtojnar