Skip to content

nixos/pam: Type all limit options#149412

Merged
dasJ merged 1 commit intoNixOS:masterfrom
helsinki-systems:feat/type-pam-options
Dec 9, 2021
Merged

nixos/pam: Type all limit options#149412
dasJ merged 1 commit intoNixOS:masterfrom
helsinki-systems:feat/type-pam-options

Conversation

@dasJ
Copy link
Copy Markdown
Member

@dasJ dasJ commented Dec 7, 2021

Motivation for this change

#76184

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 7, 2021
@dasJ dasJ mentioned this pull request Dec 7, 2021
Closed
16 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 7, 2021
@dasJ dasJ requested a review from Mic92 December 8, 2021 22:06
@ajs124 ajs124 requested a review from flokli December 8, 2021 22:49
flokli
flokli reviewed Dec 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a bit more docs, or pointers to upstream documentation. I don't really understand much from just reading the descriptions.

Also, I'm a bit worried about all the enums - are we sure that list is static enough?

nixos/modules/security/pam.nix Outdated
Copy link
Copy Markdown
Member

@flokli flokli Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to have a link to some docs here, so the choices below make a bit more sense.

@dasJ dasJ force-pushed the feat/type-pam-options branch from 2018432 to 7b5fb05 Compare December 9, 2021 11:48
@dasJ dasJ requested a review from ajs124 December 9, 2021 14:01
@dasJ dasJ merged commit 595ceaf into NixOS:master Dec 9, 2021
@dasJ dasJ deleted the feat/type-pam-options branch December 9, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flokli flokli flokli left review comments

@Mic92 Mic92 Awaiting requested review from Mic92

@ajs124 ajs124 Awaiting requested review from ajs124

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dasJ @flokli