Skip to content

yacas: Fix gui and jupyter build#147826

Merged
doronbehar merged 1 commit intoNixOS:masterfrom
doronbehar:pkg/yacas
Dec 26, 2021
Merged

yacas: Fix gui and jupyter build#147826
doronbehar merged 1 commit intoNixOS:masterfrom
doronbehar:pkg/yacas

Conversation

@doronbehar
Copy link
Copy Markdown
Contributor

@doronbehar doronbehar commented Nov 29, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Nov 29, 2021
@ofborg ofborg bot requested a review from viric November 29, 2021 10:20
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 29, 2021
@doronbehar
yacas: Fix gui and jupyter build
50ba747 
- Add a patch fixing jsoncpp include.
- Add a build flag for java support.
- Add a `yacas-gui` build that is built with Gui (and jupyter support disabled).
- Enable tests.
- Reformat expression with a 1 input / argument per line.
@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Nov 30, 2021

Now tests are enabled.

@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Dec 26, 2021

Result of nixpkgs-review pr 147826 run on x86_64-linux 1

2 packages built:
  • yacas
  • yacas-gui

@doronbehar
Copy link
Copy Markdown
Contributor Author

doronbehar commented Dec 26, 2021

Merging due to no response from maintainer.

@doronbehar doronbehar merged commit ac048e8 into NixOS:master Dec 26, 2021
@doronbehar doronbehar deleted the pkg/yacas branch March 2, 2023 10:45
@totoroot totoroot mentioned this pull request Apr 17, 2023
Closed
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viric viric Awaiting requested review from viric

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@doronbehar