Skip to content

[staging] rhash: apply clang patch unconditionally#146726

Merged
r-burns merged 1 commit intoNixOS:stagingfrom
r-burns:rhash
Nov 20, 2021
Merged

[staging] rhash: apply clang patch unconditionally#146726
r-burns merged 1 commit intoNixOS:stagingfrom
r-burns:rhash

Conversation

@r-burns
Copy link
Copy Markdown
Contributor

@r-burns r-burns commented Nov 20, 2021

The patch will be included in the next release and is safe to apply
unconditionally.
Cleanup after 2d2d472

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@r-burns
rhash: apply clang patch unconditionally
6585507 
The patch will be included in the next release and is safe to apply
unconditionally.
Cleanup after 2d2d472
@ofborg ofborg bot requested a review from andrewrk November 20, 2021 05:04
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 20, 2021
@r-burns r-burns merged commit 6b8c19e into NixOS:staging Nov 20, 2021
@r-burns r-burns deleted the rhash branch November 20, 2021 21:29
@bobby285271 bobby285271 mentioned this pull request Apr 8, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@andrewrk andrewrk Awaiting requested review from andrewrk

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r-burns @SuperSandro2000