Skip to content

lmms: build using fluidsynth 2.x#141512

Merged
sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann:lmms-fluidsynth-2
Oct 16, 2021
Merged

lmms: build using fluidsynth 2.x#141512
sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann:lmms-fluidsynth-2

Conversation

@sternenseemann
Copy link
Copy Markdown
Member

@sternenseemann sternenseemann commented Oct 13, 2021

LMMS supports building against FluidSynth 2, so there's no need to keep
using the legacy version.

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@sternenseemann
lmms: build using fluidsynth 2.x
d91a774 
LMMS supports building against FluidSynth 2, so there's no need to keep
using the legacy version.
@sternenseemann sternenseemann mentioned this pull request Oct 13, 2021
Closed
3 tasks
@ofborg ofborg bot requested a review from cillianderoiste October 13, 2021 14:53
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 13, 2021
@austinbutler
Copy link
Copy Markdown
Member

austinbutler commented Oct 16, 2021

Result of nixpkgs-review pr 141512 run on x86_64-linux 1

1 package built:
  • lmms

austinbutler
austinbutler approved these changes Oct 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@austinbutler austinbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the lmms build for me and seems to work when launched. That said, out of curiosity, what part of lmms does fluidsynth power?

@sternenseemann
Copy link
Copy Markdown
Member Author

sternenseemann commented Oct 16, 2021

That is the question…

@austinbutler
Copy link
Copy Markdown
Member

austinbutler commented Oct 16, 2021

After more searching in the codebase it seems to power at least SF2 player, and that's working fine.

@sternenseemann sternenseemann merged commit a2004d3 into NixOS:master Oct 16, 2021
@sternenseemann sternenseemann deleted the lmms-fluidsynth-2 branch October 16, 2021 21:23
@sternenseemann
Copy link
Copy Markdown
Member Author

sternenseemann commented Oct 16, 2021

Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

1 more reviewer

@austinbutler austinbutler austinbutler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sternenseemann @austinbutler