Skip to content

csound: build with fluidsynth 2.x#141506

Merged
maralorn merged 1 commit intoNixOS:masterfrom
sternenseemann:csound-fluidsynth-2
Oct 14, 2021
Merged

csound: build with fluidsynth 2.x#141506
maralorn merged 1 commit intoNixOS:masterfrom
sternenseemann:csound-fluidsynth-2

Conversation

@sternenseemann
Copy link
Copy Markdown
Member

csound has supported FluidSynth 2 since 6.13.0:
csound/csound#1106

Since fluidsynth_1 has finally been broken by glib 2.70.0, so now is a
good opportunity to get rid of this dependency.

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

csound has supported FluidSynth 2 since 6.13.0:
csound/csound#1106

Since fluidsynth_1 has finally been broken by glib 2.70.0, so now is a
good opportunity to get rid of this dependency.
@ofborg ofborg bot requested a review from MarcWeber October 13, 2021 14:02
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 13, 2021
@maralorn
Copy link
Copy Markdown
Member

I have tested csound in this PR and it seems to be running fine.

@maralorn maralorn merged commit 2b6a304 into NixOS:master Oct 14, 2021
@sternenseemann sternenseemann deleted the csound-fluidsynth-2 branch October 14, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants