Skip to content

adoptopenjdk: add 17.0.0#140116

Closed
timothyklim wants to merge 1 commit intoNixOS:masterfrom
timothyklim:jdk17
Closed

adoptopenjdk: add 17.0.0#140116
timothyklim wants to merge 1 commit intoNixOS:masterfrom
timothyklim:jdk17

Conversation

@timothyklim
Copy link
Copy Markdown
Contributor

@timothyklim timothyklim commented Oct 1, 2021

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Oct 1, 2021
@timothyklim
Copy link
Copy Markdown
Contributor Author

timothyklim commented Oct 1, 2021

/cc @SuperSandro2000

@taku0
Copy link
Copy Markdown
Contributor

taku0 commented Oct 1, 2021 •
edited
Loading

Maybe we should add separate temurin (and maybe semeru) package.

  1. Add temurin (and maybe semeru) package.
  2. Add adoptopenjdk-hotspot-bin-17 and adoptopenjdk-jre-hotspot-bin-17 to pkgs/top-level/aliases.nix that throw an error.

If it is burden, I will do it on the next weekend.

@timothyklim timothyklim closed this Oct 2, 2021
@taku0 taku0 mentioned this pull request Oct 3, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timothyklim @taku0