Skip to content

haskell.packages.ghc921: use hashable_1_3_3_0#139828

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
queezle42:ghc921-hashable
Sep 29, 2021
Merged

haskell.packages.ghc921: use hashable_1_3_3_0#139828
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
queezle42:ghc921-hashable

Conversation

@queezle42
Copy link
Copy Markdown
Contributor

@queezle42 queezle42 commented Sep 29, 2021

Motivation for this change

hashable 1.3.0 (the current stackage version) is broken on GHC 9.2.1 because it defines an instance for Option, which has been removed from base. hashable_1_3_3_0 (already available in nixpkgs) includes a fix.

Tests are still broken because random (required by QuickCheck) has not yet been updated for GHC 9.2.1.

With this change it is possible to build unordered-containers (tests also won't compile because of random).

@cdepillabout I was motivated by your comment to fix this :)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@queezle42
haskell.packages.ghc921: use hashable_1_3_3_0
41515cc 
hashable 1.3.0 is broken on GHC 9.2.1. This enables building
unordered-containers.
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Sep 29, 2021
@queezle42 queezle42 marked this pull request as draft September 29, 2021 02:30
@queezle42 queezle42 changed the base branch from master to haskell-updates September 29, 2021 02:31
@queezle42 queezle42 marked this pull request as ready for review September 29, 2021 02:32
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 29, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Sep 29, 2021
@maralorn maralorn merged commit 8eb243a into NixOS:haskell-updates Sep 29, 2021
@maralorn
Copy link
Copy Markdown
Member

maralorn commented Sep 29, 2021

Thanks!

@queezle42 queezle42 deleted the ghc921-hashable branch September 29, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@Lassulus Lassulus Awaiting requested review from Lassulus

@domenkozar domenkozar Awaiting requested review from domenkozar

@guibou guibou Awaiting requested review from guibou

@prusnak prusnak Awaiting requested review from prusnak

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@queezle42 @maralorn