Skip to content

haskell.compiler.ghc*: Use 8.10.7 bindist for bootstrapping. #139176

Merged
sternenseemann merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:ghc-use-ghc8107-for-bootstrapping
Sep 23, 2021
Merged

haskell.compiler.ghc*: Use 8.10.7 bindist for bootstrapping. #139176
sternenseemann merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:ghc-use-ghc8107-for-bootstrapping

Conversation

@sternenseemann
Copy link
Copy Markdown
Member

@sternenseemann sternenseemann commented Sep 23, 2021

Motivation for this change

#138524, rebased on top of haskell-updates with a few cleanups.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@sternenseemann sternenseemann requested a review from nh2 September 23, 2021 14:43
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Sep 23, 2021
sternenseemann
sternenseemann commented Sep 23, 2021
View reviewed changes
@sternenseemann sternenseemann mentioned this pull request Sep 23, 2021
Merged
@ofborg ofborg bot requested a review from guibou September 23, 2021 14:55
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Sep 23, 2021
nh2
nh2 approved these changes Sep 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@nh2 nh2 mentioned this pull request Sep 23, 2021
Closed
15 tasks
nh2 and others added 2 commits September 23, 2021 20:20
@nh2 @sternenseemann
haskell.compiler.ghc*: Use 8.10.7 bindist for bootstrapping.
6a53c1c 
This fixes musl+integer-simple, see NixOS#130441.

Co-Authored-By: sternenseemann <sternenseemann@systemli.org>
@sternenseemann
haskell.compiler.ghc8107: always self-bootstrap
7ef20a3 
Allows us to get rid of the musl special-casing.
@sternenseemann sternenseemann force-pushed the ghc-use-ghc8107-for-bootstrapping branch from c576b8c to 7ef20a3 Compare September 23, 2021 18:20
@sternenseemann sternenseemann merged commit 628d864 into NixOS:haskell-updates Sep 23, 2021
@sternenseemann sternenseemann deleted the ghc-use-ghc8107-for-bootstrapping branch September 23, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nh2 nh2 nh2 approved these changes

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

@maralorn maralorn Awaiting requested review from maralorn

@guibou guibou Awaiting requested review from guibou

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sternenseemann @nh2