Skip to content

haskell: add link to Hydra build report for haskell-updates branch to PR message#138772

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
cdepillabout:add-link-to-hydra-build-report
Sep 29, 2021
Merged

haskell: add link to Hydra build report for haskell-updates branch to PR message#138772
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
cdepillabout:add-link-to-hydra-build-report

Conversation

@cdepillabout
Copy link
Copy Markdown
Member

Motivation for this change

This adds a link to https://github.com/cdepillabout/nix-haskell-updates-status in the new PR message in merge-and-open-pr.sh.

I think other people than just me are using https://github.com/cdepillabout/nix-haskell-updates-status now, so I thought it would make sense to point it out in the new PR comment.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Sep 21, 2021
@cdepillabout
Copy link
Copy Markdown
Member Author

If people are interested, we could also consider moving https://github.com/cdepillabout/nix-haskell-updates-status to the NixOS organization.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 21, 2021
@cdepillabout
Copy link
Copy Markdown
Member Author

@expipiplus1 said to go for it on Matrix, so I'll go ahead and merge this in.

@sternenseemann @maralorn If you guys end up taking a look at this and don't like it, we can talk about removing it.

@cdepillabout cdepillabout merged commit 25e3fb0 into NixOS:haskell-updates Sep 29, 2021
@cdepillabout cdepillabout deleted the add-link-to-hydra-build-report branch September 29, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant