haskell: update maintainer script for merging and opening PR to also upload package versions to Hackage#138480
Merged
cdepillabout merged 2 commits intoNixOS:haskell-updatesfrom Sep 20, 2021
Conversation
642432b to
6451103
Compare
cdepillabout
commented
Sep 20, 2021
Comment on lines
21
to
+22
| curl -u "$username:$($password_command | head -n1)" --digest -H "Content-type: text/csv" -T "$package_list" http://hackage.haskell.org/distro/NixOS/packages.csv | ||
| echo |
Member
Author
There was a problem hiding this comment.
If this curl command succeeds, it returns OK! without an ending newline. Adding an echo here makes sure an ending newline is added.
Without adding this echo, the output from merge-and-open-pr.sh gets slightly messed up since there is no newline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update
maintainers/scripts/haskell/merge-and-open-pr.shto also upload Haskell package versions in NixOS to Hackage. Also update a few other log messages and info in the docs.I've used the code here to merge #138316 and open #138596, so I'm thinking this should be working well now.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)