Skip to content

haskell.packages.ghc{901,921}: use hlint_3_3_4 instead of hlint_3_3_1#137334

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
collares:hlint_3_3_4
Sep 11, 2021
Merged

haskell.packages.ghc{901,921}: use hlint_3_3_4 instead of hlint_3_3_1#137334
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
collares:hlint_3_3_4

Conversation

@collares
Copy link
Copy Markdown
Member

@collares collares commented Sep 11, 2021 •
edited
Loading

Motivation for this change

hlint_3_3_1 no longer exists. Similar to #129825.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Sep 11, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 11, 2021
@collares
Copy link
Copy Markdown
Member Author

collares commented Sep 11, 2021 •
edited
Loading

I can't really test this because base16-bytestring_0_1_1_7, pulled in by cabal-install, is broken (depends on bytestring < 0.11, which is unavailable).

Edit: Wait, I was adding the cabal-install dependency myself, and even then it's only broken for GHC 9.2.1. Sorry for the confusion. hlint works fine on GHC 9.0.1 with this PR.

@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented Sep 11, 2021 •
edited
Loading

Thanks for updating this.

I tried this locally and found basically what you're saying.

haskell.packages.ghc901.hlint now works with this PR, although dependencies for haskell.packages.ghc921.hlint still don't compile. Although this is still an improvement, since the old hlint_3_3_1 doesn't even exist anymore.

Feel free to send a follow-up PR if you're interested in getting hlint working with ghc921. We really don't have many people fixing things up in the newer GHCs here in nixpkgs.

@cdepillabout cdepillabout merged commit fa5fe8e into NixOS:haskell-updates Sep 11, 2021
@queezle42 queezle42 mentioned this pull request Sep 29, 2021
Merged
12 tasks
@collares collares deleted the hlint_3_3_4 branch December 20, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@collares @cdepillabout