Skip to content

termonad: add meta.mainProgram to easily run with flakes#136350

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
cdepillabout:termonad-fixup
Sep 1, 2021
Merged

termonad: add meta.mainProgram to easily run with flakes#136350
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
cdepillabout:termonad-fixup

Conversation

@cdepillabout
Copy link
Copy Markdown
Member

@cdepillabout cdepillabout commented Sep 1, 2021 •
edited
Loading

Motivation for this change

I added a meta.mainProgram value for Termonad to make it easy to do nix run nixpkgs#termonad (or nix run nixpkgs#termonad-with-packages).

I've also added a top-level termonad key that is easier to understand than termonad-with-packages.

At some point it might make sense to deprecate the termonad-with-packages alias.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@cdepillabout
termonad: add meta.mainProgram to easily run with flakes
2fe1993 
This also adds a top-level `termonad` alias for
`termonad-with-packages`.
@cdepillabout cdepillabout mentioned this pull request Sep 1, 2021
Closed
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 1, 2021
teto
teto approved these changes Sep 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let you merge if you consider this ready. Looks good to me.

@cdepillabout cdepillabout merged commit 5a26260 into NixOS:haskell-updates Sep 1, 2021
@cdepillabout cdepillabout added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Sep 1, 2021
@cdepillabout cdepillabout deleted the termonad-fixup branch November 1, 2021 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teto teto teto approved these changes

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cdepillabout @teto