Skip to content

merkaartor: 0.18.4 → 0.19.0#135925

Merged
erictapen merged 1 commit intoNixOS:masterfrom
sikmir:merkaartor
Aug 29, 2021
Merged

merkaartor: 0.18.4 → 0.19.0#135925
erictapen merged 1 commit intoNixOS:masterfrom
sikmir:merkaartor

Conversation

@sikmir
Copy link
Copy Markdown
Member

@sikmir sikmir commented Aug 27, 2021 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 27, 2021
erictapen
erictapen approved these changes Aug 29, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs for me fine, thanks!

@erictapen erictapen merged commit 224cbaf into NixOS:master Aug 29, 2021
@sikmir sikmir deleted the merkaartor branch August 30, 2021 08:44
@sikmir sikmir mentioned this pull request Aug 31, 2021
Merged
12 tasks
@sikmir
Copy link
Copy Markdown
Member Author

sikmir commented Aug 31, 2021

@erictapen sha256 hash changed for some reason, I have no idea why.

@veprbl veprbl mentioned this pull request Dec 17, 2021
Closed
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erictapen erictapen erictapen approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sikmir @erictapen