Closed
Conversation
Use common style
`--set FOO ""` is not strictly equivalent to `--unset FOO`. In the former case the environment variable still exists with an empty string as a value.
| echo exec ${argv0:+-a $argv0} "$original" \ | ||
| $flagsBefore '"${extraFlagsArray[@]}"' '"$@"' >> $wrapper | ||
| echo "exec ${argv0:+-a $argv0 }$original" \ | ||
| "$flagsBefore" '"${extraFlagsArray[@]}"' '"$@"' >> "$wrapper" |
Member
Author
There was a problem hiding this comment.
I need to fix the escaping of $flagsBefore here
Member
|
These are mass-rebuilding changes; please make this PR against the staging branch. |
Member
Author
|
Okay. Should I re-open another PR ? I don't think github allows me to switch the target. |
Member
|
Looks good. Didn't know that quotes are unnecessary in |
Contributor
IMHO |
Member
Yes. Sorry! |
Member
Author
|
Alright, everyone to the batmobile ! #13543 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done:
nix-build --option build-use-chroot trueor nix.useChroot on NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Using ShellCheck to make sure all of our bash is escaped properly. Is this something desirable ?
There are a couple of things I see as controversial in these changes:
Use
#!bashis a hack that lets vim and shellcheck know that we are dealing with a bash dialect. The file itself is not executable because a shebang needs an absolute path (thus /usr/bin/env's existance).Use
[[ ]]over the POSIX[ ]ortestsyntax. Mainly because it's smarter in regards to escaping and less likely to mis-use.A new
--unsetoption that I bundle with these changes because of the mass-rebuild.This is not done yet, just seeking for confirmation if this is a good idea or not. Also trying to see if we can agree on a bash style.
/cc @edolstra @domenkozar