Skip to content

python3Packages.class-registry: 2.1.2 -> 3.0.5#133343

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
fabaff:bump-class-registry
Sep 29, 2021
Merged

python3Packages.class-registry: 2.1.2 -> 3.0.5#133343
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
fabaff:bump-class-registry

Conversation

@fabaff
Copy link
Copy Markdown
Member

@fabaff fabaff commented Aug 10, 2021

Motivation for this change

Update to latest upstream release 3.0.5

Change log: https://github.com/todofixthis/class-registry/releases/tag/3.0.5

  • Enable tests
  • Cleanup
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff fabaff requested review from FRidh and jonringer as code owners August 10, 2021 09:31
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 10, 2021
@ofborg ofborg bot requested a review from kevincox August 10, 2021 09:42
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 10, 2021
@fabaff fabaff mentioned this pull request Aug 10, 2021
Merged
11 tasks
@fabaff fabaff force-pushed the bump-class-registry branch from b73be70 to 503009b Compare August 10, 2021 10:26
@kevincox
Copy link
Copy Markdown
Contributor

kevincox commented Aug 10, 2021

Result of nixpkgs-review pr 133343 run on x86_64-linux 1

1 package failed to build:
  • backblaze-b2
2 packages built:
  • python38Packages.class-registry
  • python39Packages.class-registry

kevincox
kevincox reviewed Aug 10, 2021
View reviewed changes
pkgs/development/python-modules/class-registry/default.nix Outdated
Copy link
Copy Markdown
Contributor

@kevincox kevincox Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but the only dependent package is now failing. If you are adding the v3 for your own use you may need to fork the package into v2 and v3. Otherwise please fix backblaze-b2.

Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A python package is duplicated. We just need to remove the duplicated package and then it should just work.

@r-rmcgibbo
Copy link
Copy Markdown

r-rmcgibbo commented Aug 11, 2021

Result of nixpkgs-review pr 133343 at 503009b6 run on x86_64-linux 1

1 package failed to build:
2 packages built successfully:
  • python38Packages.class-registry
  • python39Packages.class-registry

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Aug 11, 2021

backblaze-b2 fails with:

              >   phx-class-registry 3.0.5 (/nix/store/100fngyf29gkfpn8r7g7jhldx1aa82rq-python3.9-class-registry-3.0.5/lib/python3.9/site-packages)
              >   phx-class-registry 3.0.5 (/nix/store/cbn8saxr2zmca801dbzxlqllcw11rn3k-python3.9-phx-class-registry-3.0.5/lib/python3.9/site-packages)

@fabaff fabaff force-pushed the bump-class-registry branch from 503009b to e45dd4b Compare September 29, 2021 13:23
@ofborg ofborg bot requested a review from kevincox September 29, 2021 13:35
@SuperSandro2000 SuperSandro2000 merged commit e6f186c into NixOS:master Sep 29, 2021
@fabaff fabaff deleted the bump-class-registry branch September 30, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@kevincox kevincox Awaiting requested review from kevincox

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fabaff @kevincox @r-rmcgibbo @SuperSandro2000