Skip to content

haskell.compiler.ghcHEAD: 9.3.20210504 -> 9.3.20210806#133309

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
utdemir:ud/update-ghc-head-2021080
Aug 10, 2021
Merged

haskell.compiler.ghcHEAD: 9.3.20210504 -> 9.3.20210806#133309
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
utdemir:ud/update-ghc-head-2021080

Conversation

@utdemir
Copy link
Copy Markdown
Member

@utdemir utdemir commented Aug 9, 2021 •
edited
Loading

Motivation for this change

Just bumping the ghcHEAD revision, there're some performance improvements there.

I checked that the resulting ghc can compile code.

However, there was an issue with the hscolour package (with or without this PR), so I couldn't try building a Haskell package with Nix. In my opinion, that's a separate issues ince this PR is not making things worse.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Aug 9, 2021
@ofborg ofborg bot requested review from MarcWeber, kosmikus and peti August 9, 2021 23:53
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 9, 2021
@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented Aug 10, 2021

Thanks! This seems reasonable, and it looks like it is building at least on Linux.

@utdemir I'll go ahead and merge this in, but can you keep an eye on Hydra and/or https://github.com/cdepillabout/nix-haskell-updates-status the next 24 hours or so to make sure that this doesn't cause any additional breakage?

@cdepillabout cdepillabout merged commit debd994 into NixOS:haskell-updates Aug 10, 2021
@utdemir
Copy link
Copy Markdown
Member Author

utdemir commented Aug 10, 2021

Thanks @cdepillabout . I'll keep an eye on it.

@utdemir
Copy link
Copy Markdown
Member Author

utdemir commented Aug 11, 2021

@cdepillabout , well, it did not build on darwin, because a dependency has failed (that does not seem relevant to this PR).

When I look at the Hydra jobset evaluations, I don't see a large number of changes to the failed jobs, which looks promising; however when I search for haskell.packages.ghcHEAD on the Jobs tab I don't get any results, I was expecting to get some.

So, in the end I noticed that I don't really know what to look at on Hydra. Sorry to leave this to you, but could you also have a look to see if everything is ok?

@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented Aug 11, 2021

@utdemir Thanks for following up.

On our build reports, it looks like haskell.compiler.ghcHEAD is just timing out on Darwin:

https://github.com/cdepillabout/nix-haskell-updates-status/blob/48be9e27c81bc436abc012fe4d050eed440a768f/README.md

If you click through, you can find the job that is timing out:

https://hydra.nixos.org/build/149762652

I took a quick look at this, and I think this is happening because the derivation for ghcHEAD doesn't have meta.timeout set, while the other GHCs derivations do.

ghcHEAD:

nixpkgs/pkgs/development/compilers/ghc/head.nix

Lines 310 to 317 in c84e14d

meta = {
homepage = "http://haskell.org/ghc";
description = "The Glasgow Haskell Compiler";
maintainers = with lib.maintainers; [ marcweber andres peti ];
inherit (ghc.meta) license platforms;
# ghcHEAD times out on aarch64-linux on Hydra.
hydraPlatforms = builtins.filter (p: p != "aarch64-linux") ghc.meta.platforms;
};

ghc901:

nixpkgs/pkgs/development/compilers/ghc/9.0.1.nix

Lines 293 to 303 in c84e14d

meta = {
homepage = "http://haskell.org/ghc";
description = "The Glasgow Haskell Compiler";
maintainers = with lib.maintainers; [ marcweber andres peti ];
timeout = 24 * 3600;
inherit (ghc.meta) license platforms;
# integer-simple builds are broken when GHC links against musl.
# See https://github.com/NixOS/nixpkgs/pull/129606#issuecomment-881323743.
broken = enableIntegerSimple && hostPlatform.isMusl;
};

I fixed this by adding the timeout = line to the ghcHEAD derivation as well in 2d1b5aa on #133422.

Hopefully this should cause the timeout to not happen anymore.

@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented Aug 11, 2021

when I search for haskell.packages.ghcHEAD on the Jobs tab I don't get any results, I was expecting to get some

Ah, so we don't actually build any packages from haskell.packages.ghcHEAD on Hydra. We don't really expect that any packages will be able to be built. But we still provide haskell.compiler.ghcHEAD for users that want to use it, and build it on Hydra.

So the only thing you should be able to find a job for is haskell.compiler.ghcHEAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@peti peti Awaiting requested review from peti

@MarcWeber MarcWeber Awaiting requested review from MarcWeber

@kosmikus kosmikus Awaiting requested review from kosmikus

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@utdemir @cdepillabout