Skip to content

libantlr3c: fix build on non x86 platforms#132994

Merged
sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann:libantlr3c-aarch64
Aug 21, 2021
Merged

libantlr3c: fix build on non x86 platforms#132994
sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann:libantlr3c-aarch64

Conversation

@sternenseemann
Copy link
Copy Markdown
Member

@sternenseemann sternenseemann commented Aug 7, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Copy Markdown
Member Author

sternenseemann commented Aug 7, 2021

@ofborg build libantlr3c

SuperSandro2000
SuperSandro2000 approved these changes Aug 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@ofborg ofborg bot requested a review from vbgl August 7, 2021 10:09
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 7, 2021
@sternenseemann sternenseemann mentioned this pull request Aug 7, 2021
Merged
sternenseemann referenced this pull request Aug 10, 2021
@maralorn
haskellPackages.hevm: Fix eval by disabling on aarch64
844bb64
@sternenseemann sternenseemann merged commit 96768d0 into NixOS:master Aug 21, 2021
@sternenseemann sternenseemann deleted the libantlr3c-aarch64 branch August 21, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@vbgl vbgl Awaiting requested review from vbgl

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sternenseemann @SuperSandro2000