Skip to content

stdenv: switch shell to oil#131676

Closed
happysalada wants to merge 6 commits intoNixOS:stagingfrom
happysalada:oil_shell_test
Closed

stdenv: switch shell to oil#131676
happysalada wants to merge 6 commits intoNixOS:stagingfrom
happysalada:oil_shell_test

Conversation

@happysalada
Copy link
Copy Markdown
Contributor

@happysalada happysalada commented Jul 27, 2021 •
edited
Loading

Motivation for this change

This is a draft PR to test switching the shell to oil shell.
My first try involved setting strict execution options for the shell which are not necessary. (oil:strict_all is like enabling the e and u flag).
This PR is not meant to be merged as is, it's just a way to test the potential failures.
I've successfully built bash, I'm not sure what to test next.

@zimbatm this is basically your code. Thanks again for initiating this!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Jul 27, 2021
@happysalada happysalada marked this pull request as draft July 27, 2021 12:27
@happysalada
Copy link
Copy Markdown
Contributor Author

happysalada commented Jul 27, 2021

I have no idea why the editor config is failing.
If I can still get an evaluation, then it doesn't matter.

@happysalada happysalada force-pushed the oil_shell_test branch 2 times, most recently from ec93066 to f09751f Compare July 28, 2021 08:59
@happysalada happysalada mentioned this pull request Aug 13, 2021
Closed
@happysalada happysalada force-pushed the oil_shell_test branch 2 times, most recently from 3700d1f to 6b872ae Compare November 26, 2021 05:41
@github-actions github-actions bot added 6.topic: cinnamon Desktop environment 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: kernel The Linux kernel 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: nim Nim programing language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: pantheon The Pantheon desktop environment 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: vim Advanced text editor 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 10, 2021
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2021
@github-actions github-actions bot removed 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: nim Nim programing language 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: vim Advanced text editor 6.topic: cinnamon Desktop environment 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: kernel The Linux kernel 6.topic: pantheon The Pantheon desktop environment 8.has: documentation This PR adds or changes documentation 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: xfce The Xfce Desktop Environment 6.topic: steam Steam game store/launcher (store.steampowered.com) labels Dec 30, 2021
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 30, 2021
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 10, 2022
@adamcstephens adamcstephens mentioned this pull request Mar 17, 2023
Closed
10 tasks
@happysalada happysalada deleted the oil_shell_test branch April 28, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: stdenv Standard environment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@happysalada