Skip to content

stdenv: separate command and conditional#131162

Closed
happysalada wants to merge 1 commit intoNixOS:stagingfrom
happysalada:stdenv_separate_command_conditional
Closed

stdenv: separate command and conditional#131162
happysalada wants to merge 1 commit intoNixOS:stagingfrom
happysalada:stdenv_separate_command_conditional

Conversation

@happysalada
Copy link
Copy Markdown
Contributor

@happysalada happysalada commented Jul 23, 2021

Motivation for this change

This is part of a series of PR to improve the stdenv shell scripts

This extracts out a command from a conditional. an exit code is swallowed when a command is run in a conditional.
Admittedly, the semantics don't change here and it's a little more verbose.
I would understand if some people might be opposed to it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Jul 23, 2021
@happysalada happysalada mentioned this pull request Jul 23, 2021
Merged
11 tasks
@stale
Copy link
Copy Markdown

stale bot commented Apr 19, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 19, 2022
@teto
Copy link
Copy Markdown
Member

teto commented Apr 19, 2022

but you do nothing with the status ? if anything it should be added to the echo command. What's the motivation ?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 19, 2022
@happysalada
Copy link
Copy Markdown
Contributor Author

happysalada commented Apr 19, 2022

you might be right here, I unfortunately don't have the time to pursue this meaningfully.

@happysalada happysalada deleted the stdenv_separate_command_conditional branch April 28, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

6.topic: stdenv Standard environment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@happysalada @teto