Closed
Conversation
Contributor
Author
|
It looks like the expand params is a problem to build ld. |
12 tasks
Contributor
Author
|
I'm realising slowly what the expandParams does, this seems like faulty logic, I'm going to close this for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is part of a series of PR that aims at bringing shell improvements.
I'm trying to target staging directly for this one to see if the build gets done in a timely manner (rather than target master to get higher priority)
This PR needs testing, because I'm not exactly sure what is happening with the "@expandResponseParams@" thing. It seems to me that the code would work, however, it needs confirmation.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)