Skip to content

stdenv: use named ref#131160

Closed
happysalada wants to merge 1 commit intoNixOS:stagingfrom
happysalada:stdenv_expand_respond_params_named_ref
Closed

stdenv: use named ref#131160
happysalada wants to merge 1 commit intoNixOS:stagingfrom
happysalada:stdenv_expand_respond_params_named_ref

Conversation

@happysalada
Copy link
Copy Markdown
Contributor

Motivation for this change

This is part of a series of PR that aims at bringing shell improvements.

I'm trying to target staging directly for this one to see if the build gets done in a timely manner (rather than target master to get higher priority)

This PR needs testing, because I'm not exactly sure what is happening with the "@expandResponseParams@" thing. It seems to me that the code would work, however, it needs confirmation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@happysalada happysalada requested a review from Ericson2314 as a code owner July 23, 2021 02:51
@happysalada happysalada mentioned this pull request Jul 23, 2021
11 tasks
@happysalada
Copy link
Copy Markdown
Contributor Author

It looks like the expand params is a problem to build ld.
I need to investigate.

@happysalada happysalada mentioned this pull request Sep 26, 2021
12 tasks
@happysalada
Copy link
Copy Markdown
Contributor Author

I'm realising slowly what the expandParams does, this seems like faulty logic, I'm going to close this for now

@happysalada happysalada deleted the stdenv_expand_respond_params_named_ref branch September 28, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant