stdenv: replace string expasion with array element check#130621
Closed
happysalada wants to merge 1 commit intoNixOS:stagingfrom
Closed
stdenv: replace string expasion with array element check#130621happysalada wants to merge 1 commit intoNixOS:stagingfrom
happysalada wants to merge 1 commit intoNixOS:stagingfrom
Conversation
|
I marked this as stale due to inactivity. → More info |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This commit removes a string expansion to check array inclusion in favor of an array traversal.
It uses a named reference since that is perceived to be the code's intent.
(this removes an eval as a positive side effect).
Note that this change comes from a problematic commit and it was proposed in a previous PR.
@aszlig thank you for reviewing this the first time!
I believe that even though the resulting code is slightly different, the semantic meaning should be preserved. I do want to try a hydra test to make sure of my hypothesis.
https://github.com/NixOS/nixpkgs/pull/129903/files
The original commit with some comments bf99a81
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)