appimageTools.wrapAppImage: Fix passing arguments to wrapped executable#128927
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Jul 21, 2021
Merged
appimageTools.wrapAppImage: Fix passing arguments to wrapped executable#128927Mic92 merged 1 commit intoNixOS:masterfrom
Mic92 merged 1 commit intoNixOS:masterfrom
Conversation
appimage-exec.sh parses its arguments with getopts, so we need to delimit arguments intended for the wrapped executable with ‘--’, in case some of them begin with ‘-’. Without this fix, a wrapped application like Zulip Desktop can’t be opened the normal way using the .desktop file, which includes ‘Exec=zulip --no-sandbox %U’ (as per the electron-builder default): $ gtk-launch zulip.desktop /usr/bin/appimage-exec.sh: illegal option -- - Usage: appimage-run [appimage-run options] <AppImage> [AppImage options] […] Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Member
|
@ofborg eval (Sorry, ofborg's certs recently had an issue, meaning that it was unable to |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
appimage-exec.shparses its arguments withgetopts, so we need to delimit arguments intended for the wrapped executable with--, in case some of them begin with-.Without this fix, a wrapped application like Zulip Desktop can’t be opened the normal way using the
.desktopfile, which includesExec=zulip --no-sandbox %U(as per the electron-builder default):Cc @bignaux (author of #81833)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)