Skip to content

haskellPackages: remove haskell-gi overrides obsolete due to lts#127552

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
sternenseemann:haskell-stackage-gi-0.25
Jun 20, 2021
Merged

haskellPackages: remove haskell-gi overrides obsolete due to lts#127552
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
sternenseemann:haskell-stackage-gi-0.25

Conversation

@sternenseemann
Copy link
Copy Markdown
Member

@sternenseemann sternenseemann commented Jun 20, 2021

stackage LTS 18 luckily updated haskell-gi and related libraries to
0.25, so we can remove a lot of overrides. I also unrestricted some of
them in configuration-hackage2nix/main.yml and removed the overrides
updating them in configuration-common.nix (I guess the person doing
the upgrades thought those libraries were also in stackage).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@sternenseemann
haskellPackages: remove haskell-gi overrides obsolete due to lts
1ff77ab 
stackage LTS 18 luckily updated haskell-gi and related libraries to
0.25, so we can remove a lot of overrides. I also unrestricted some of
them in configuration-hackage2nix/main.yml and removed the overrides
updating them in configuration-common.nix (I guess the person doing
the upgrades thought those libraries were also in stackage).
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jun 20, 2021
@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented Jun 20, 2021

I tried building all of these (as well as Termonad) locally on x86-64 linux and they all build.

LGTM

@cdepillabout cdepillabout merged commit 863f7de into NixOS:haskell-updates Jun 20, 2021
@maralorn
Copy link
Copy Markdown
Member

maralorn commented Jun 20, 2021

Thank you!

@sternenseemann sternenseemann deleted the haskell-stackage-gi-0.25 branch June 20, 2021 17:31
@sternenseemann
Copy link
Copy Markdown
Member Author

sternenseemann commented Jun 20, 2021

The remaining serious eval error is related to the hlint downgrade we already discussed, I've not touched that so far because there doesn't seem to be a consensus on what to do so far (I think?).

@sternenseemann sternenseemann restored the haskell-stackage-gi-0.25 branch July 24, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@expipiplus1 expipiplus1 Awaiting requested review from expipiplus1

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sternenseemann @cdepillabout @maralorn