Skip to content

faust: fix compiler flags when used outside nix shell#126808

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
pmahoney:faust-outside-nix-shell
Jun 14, 2021
Merged

faust: fix compiler flags when used outside nix shell#126808
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
pmahoney:faust-outside-nix-shell

Conversation

@pmahoney
Copy link
Copy Markdown
Contributor

@pmahoney pmahoney commented Jun 14, 2021

Fixes #78610

The issue is some additional environment variables added to the nix
compiler wrappers that also need to be exported by the faust
wrapper.

This "wrapWithBuildEnv" solution is very hacky, but I
don't know of a better solution.

Motivation for this change

Many faust scripts not working outside of nix-shell

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@pmahoney
faust: fix compiler flags when used outside nix shell
ceed1e2 
Fixes NixOS#78610

The issue is some additional environment variables added to the nix
compiler wrappers that also need to be exported by the faust
wrapper.

This "wrapWithBuildEnv" solution is very hacky, but I
don't know of a better solution.
@pmahoney pmahoney mentioned this pull request Jun 14, 2021
Closed
@pmahoney pmahoney requested a review from magnetophon June 14, 2021 03:55
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 14, 2021
@r-rmcgibbo
Copy link
Copy Markdown

r-rmcgibbo commented Jun 14, 2021 •
edited
Loading

Result of nixpkgs-review pr 126808 at ceed1e2 run on aarch64-linux 1

10 packages built successfully:
  • faust2alqt
  • faust2alsa
  • faust2csound
  • faust2jack
  • faust2jackrust
  • faust2jaqt
  • faust2ladspa
  • faust2lv2
  • faustPhysicalModeling
  • faustStk

Result of nixpkgs-review pr 126808 at ceed1e2 run on x86_64-linux 1

1 package skipped due to time constraints:
  • magnetophonDSP.VoiceOfFaust
21 packages built successfully:
  • faust2alqt
  • faust2alsa
  • faust2csound
  • faust2jack
  • faust2jackrust
  • faust2jaqt
  • faust2ladspa
  • faust2lv2
  • faustPhysicalModeling
  • faustStk
  • magnetophonDSP.CharacterCompressor
  • magnetophonDSP.CompBus
  • magnetophonDSP.ConstantDetuneChorus
  • magnetophonDSP.LazyLimiter
  • magnetophonDSP.MBdistortion
  • magnetophonDSP.RhythmDelay
  • magnetophonDSP.faustCompressors
  • magnetophonDSP.pluginUtils
  • magnetophonDSP.shelfMultiBand
  • mooSpace
  • tambura
12 suggestions:
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern ' error ' doesn't match anything in file '/nix/store/az3vn2d1vwmc23kmdwpzxrkvrzh5d806-faust2jaqt-2.30.5/bin/faust2jackserver'
    Near pkgs/applications/audio/faust/faust2.nix:143:0:

        |
143 |         description = "The ${baseName} script, part of faust functional programming language for realtime audio signal processing";
    | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern ' error ' doesn't match anything in file '/nix/store/az3vn2d1vwmc23kmdwpzxrkvrzh5d806-faust2jaqt-2.30.5/bin/faust2jaqt'
    Near pkgs/applications/audio/faust/faust2.nix:143:0:

        |
143 |         description = "The ${baseName} script, part of faust functional programming language for realtime audio signal processing";
    | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern ' error ' doesn't match anything in file '/nix/store/zi90nhd2g8bpdban4d59n8yq5kwhizw2-faust2ladspa-2.30.5/bin/faust2ladspa'
    Near pkgs/applications/audio/faust/faust2.nix:143:0:

        |
143 |         description = "The ${baseName} script, part of faust functional programming language for realtime audio signal processing";
    | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern ' error ' doesn't match anything in file '/nix/store/cv22gvs8z48vxfvvkn5vnnfcgxm554gf-faust2csound-2.30.5/bin/faust2csound'
    Near pkgs/applications/audio/faust/faust2.nix:143:0:

        |
143 |         description = "The ${baseName} script, part of faust functional programming language for realtime audio signal processing";
    | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern ' error ' doesn't match anything in file '/nix/store/r61f0alpywlfzni5hp459w1fcplnmfbs-faust2alqt-2.30.5/bin/faust2alqt'
    Near pkgs/applications/audio/faust/faust2.nix:143:0:

        |
143 |         description = "The ${baseName} script, part of faust functional programming language for realtime audio signal processing";
    | ^
  • warning: unused-argument

    Unused argument: baseName.
    Near pkgs/applications/audio/faust/faust2.nix:164:7:

        |
164 |     { baseName
    |       ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern ' error ' doesn't match anything in file '/nix/store/s6ykg5lxmq45d4xgk5p7crbld4647ghp-faust2jack-2.30.5/bin/faust2jack'
    Near pkgs/applications/audio/faust/faust2.nix:143:0:

        |
143 |         description = "The ${baseName} script, part of faust functional programming language for realtime audio signal processing";
    | ^
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/applications/audio/faust/faust2.nix:36:5:

       |
36 |     license = licenses.gpl2;
   |     ^
  • warning: unused-argument

    Unused argument: baseName.
    Near pkgs/applications/audio/faust/faust2.nix:208:7:

        |
208 |     { baseName
    |       ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern ' error ' doesn't match anything in file '/nix/store/8mjnmcc4l2d30xsb332gp403nynfq0m4-faust2alsa-2.30.5/bin/faust2alsa'
    Near pkgs/applications/audio/faust/faust2.nix:143:0:

        |
143 |         description = "The ${baseName} script, part of faust functional programming language for realtime audio signal processing";
    | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern ' error ' doesn't match anything in file '/nix/store/s6ykg5lxmq45d4xgk5p7crbld4647ghp-faust2jack-2.30.5/bin/faust2jackconsole'
    Near pkgs/applications/audio/faust/faust2.nix:143:0:

        |
143 |         description = "The ${baseName} script, part of faust functional programming language for realtime audio signal processing";
    | ^
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern ' error ' doesn't match anything in file '/nix/store/xy8yliyhpp28dsdbhp0mfy9sn10h1bw3-faust2jackrust-2.30.5/bin/faust2jackrust'
    Near pkgs/applications/audio/faust/faust2.nix:143:0:

        |
143 |         description = "The ${baseName} script, part of faust functional programming language for realtime audio signal processing";
    | ^

@SuperSandro2000 SuperSandro2000 merged commit 971c744 into NixOS:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@magnetophon magnetophon magnetophon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some faust scripts only work in nix-shell

4 participants

@pmahoney @r-rmcgibbo @magnetophon @SuperSandro2000