Skip to content

haskellPackages.arch-web: unbreak#125327

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
berberman:arch-web
Jun 2, 2021
Merged

haskellPackages.arch-web: unbreak#125327
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
berberman:arch-web

Conversation

@berberman
Copy link
Copy Markdown
Member

@berberman berberman commented Jun 2, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jun 2, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 2, 2021
@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented Jun 2, 2021

LGTM, thanks for fixing this!

Also, it feels somewhat funny to have this package working in nixpkgs: Arch Linux official and AUR web interface binding. Although I imagine it could be helpful for someone using Nix on Arch.

@cdepillabout cdepillabout merged commit b24ae98 into NixOS:haskell-updates Jun 2, 2021
@berberman
Copy link
Copy Markdown
Member Author

berberman commented Jun 2, 2021

LOL, I'm a contributor of Haskell package set in Arch Linux official repo, but I do almost all my works on NixOS now XD

@berberman berberman deleted the arch-web branch June 2, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@berberman @cdepillabout