Skip to content

Aarch64 darwin eval#125184

Merged
domenkozar merged 4 commits intoNixOS:masterfrom
domenkozar:aarch64-darwin-eval
Jun 3, 2021
Merged

Aarch64 darwin eval#125184
domenkozar merged 4 commits intoNixOS:masterfrom
domenkozar:aarch64-darwin-eval

Conversation

@domenkozar
Copy link
Copy Markdown
Member

@domenkozar domenkozar commented Jun 1, 2021 •
edited
Loading

Fixes required for nix-build pkgs/top-level/release.nix -A tarball to pass when using aarch64-darwin as supported platform.

@thefloweringash @domenkozar
(darwin) openjdk8: 8.0.202 -> 8.0.292
1629efe 
Also adds aarch64-darwin support

(cherry picked from commit 00090e0)
Signed-off-by: Domen Kožar <domen@dev.si>
@thefloweringash @domenkozar
(darwin) openjdk11: 11.0.9 -> 11.0.11
a5b2f79 
Also adds aarch64-darwin support

(cherry picked from commit 1b006e3)
Signed-off-by: Domen Kožar <domen@dev.si>
@thefloweringash @domenkozar
(darwin) openjdk: 16.0.0 -> 16.0.1
ccb99f6 
Also adds aarch64-darwin support

(cherry picked from commit 4288adb)
Signed-off-by: Domen Kožar <domen@dev.si>
@domenkozar domenkozar requested review from a user and thefloweringash June 1, 2021 09:21
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 1, 2021
@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Jun 1, 2021
@domenkozar domenkozar mentioned this pull request Jun 1, 2021
Closed
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 1, 2021
@ofborg ofborg bot requested review from 7c6f434c, dtzWill, lovek323 and primeos June 1, 2021 09:31
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 1, 2021
This was referenced Jun 1, 2021
Merged
Closed
thefloweringash
thefloweringash reviewed Jun 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@thefloweringash thefloweringash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: how does an assert failure differ from a nested evaluation failure?

@domenkozar
Copy link
Copy Markdown
Member Author

domenkozar commented Jun 2, 2021

General question: how does an assert failure differ from a nested evaluation failure?

My understanding is that Hydra allows certain evaluation failures like from assert, but not the general case.

@domenkozar domenkozar force-pushed the aarch64-darwin-eval branch from dddde95 to ef3a053 Compare June 2, 2021 14:53
@github-actions github-actions bot removed the 6.topic: qt/kde Object-oriented framework for GUI creation label Jun 2, 2021
@domenkozar
Copy link
Copy Markdown
Member Author

domenkozar commented Jun 2, 2021

@thefloweringash thanks for the review, PTAL

@ofborg ofborg bot requested a review from pmahoney June 2, 2021 15:02
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Jun 2, 2021

This exception handling is certainly more generic than just in Hydra, e.g. nix-env -qa does it as well. throw and failed assert make the package to be skipped , and we use these also for meta.broken, meta.platforms. You get a hard error on builtins.abort or various language errors (e.g. accessing nonexistent attribute without or fallback).

@domenkozar domenkozar mentioned this pull request Jun 2, 2021
Merged
Ericson2314
Ericson2314 reviewed Jun 2, 2021
View reviewed changes
thefloweringash
thefloweringash reviewed Jun 3, 2021
View reviewed changes
@domenkozar domenkozar force-pushed the aarch64-darwin-eval branch from ef3a053 to 1b3cb80 Compare June 3, 2021 08:51
@domenkozar
Copy link
Copy Markdown
Member Author

domenkozar commented Jun 3, 2021

PTAL :)

@domenkozar domenkozar force-pushed the aarch64-darwin-eval branch from 1b3cb80 to 9e6417f Compare June 3, 2021 08:52
thefloweringash
thefloweringash approved these changes Jun 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@thefloweringash thefloweringash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domenkozar domenkozar merged commit aeb44a8 into NixOS:master Jun 3, 2021
@malob malob mentioned this pull request Aug 18, 2022
Open
@rrbutani rrbutani mentioned this pull request Jan 8, 2023
Merged
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Ericson2314 left review comments

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@ttuegel ttuegel Awaiting requested review from ttuegel

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@dtzWill dtzWill Awaiting requested review from dtzWill

@lovek323 lovek323 Awaiting requested review from lovek323

@primeos primeos Awaiting requested review from primeos

@pmahoney pmahoney Awaiting requested review from pmahoney

+1 more reviewer

@thefloweringash thefloweringash thefloweringash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@domenkozar @vcunat @thefloweringash @Ericson2314