Skip to content

bibletime: 2.11.2 -> 3.0#125162

Merged
veprbl merged 1 commit intoNixOS:masterfrom
andreoss:master
Jun 2, 2021
Merged

bibletime: 2.11.2 -> 3.0#125162
veprbl merged 1 commit intoNixOS:masterfrom
andreoss:master

Conversation

@andreoss
Copy link
Copy Markdown
Contributor

@andreoss andreoss commented Jun 1, 2021

Motivation for this change

Update to the newest version

Things done

Bump version & fix build

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

veprbl
veprbl reviewed Jun 1, 2021
View reviewed changes
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 1, 2021
@r-rmcgibbo
Copy link
Copy Markdown

r-rmcgibbo commented Jun 1, 2021

Result of nixpkgs-review pr 125162 at 7c285ec8 run on x86_64-linux 1

1 package built successfully:
  • bibletime
2 suggestions:
  • warning: build-tools-in-build-inputs

    docbook_xml_dtd_45 is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/misc/bibletime/default.nix:18:3:

       |
18 |   buildInputs = [
   |   ^
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/applications/misc/bibletime/default.nix:48:5:

       |
48 |     license = lib.licenses.gpl2;
   |     ^

@veprbl veprbl mentioned this pull request Jun 1, 2021
Closed
69 tasks
@veprbl veprbl merged commit 5c0c8d2 into NixOS:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl left review comments

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreoss @r-rmcgibbo @veprbl