Skip to content

haskellPackages.nvfetcher: add to top-level#124719

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
berberman:nvfetcher
May 28, 2021
Merged

haskellPackages.nvfetcher: add to top-level#124719
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
berberman:nvfetcher

Conversation

@berberman
Copy link
Copy Markdown
Member

@berberman berberman commented May 28, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 28, 2021
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 28, 2021
@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented May 28, 2021

@GrahamcOfBorg build nvfetcher

@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented May 28, 2021

This looks good, thanks for adding yourself as maintainer!

@cdepillabout cdepillabout merged commit aa21d85 into NixOS:haskell-updates May 28, 2021
@berberman berberman deleted the nvfetcher branch May 28, 2021 04:26
@maralorn
Copy link
Copy Markdown
Member

maralorn commented May 28, 2021

Question: We lately had a trend to move overrides which actually fix packages move into configuration-common.nix. I think that would have been better in this context, too. (Concretely: Have only the justStaticExecutable on the top-level.)
Do we want to continue that? Or are there reasons to keep overrides like this only on the top-level?

@berberman
Copy link
Copy Markdown
Member Author

berberman commented May 28, 2021

Thanks for noting that, the upcoming version requires generateOptparseApplicativeCompletion, and I'll add this new one and move them to configuration-common.nix at once.

@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented May 28, 2021

@maralorn Ah, good point. I'll make sure to check for that in the future.

@berberman berberman mentioned this pull request Jun 9, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@berberman @cdepillabout @maralorn