glibc: allow to build position-independent static executable#123989
Merged
Mic92 merged 3 commits intoNixOS:stagingfrom May 25, 2021
Merged
glibc: allow to build position-independent static executable#123989Mic92 merged 3 commits intoNixOS:stagingfrom
Mic92 merged 3 commits intoNixOS:stagingfrom
Conversation
Member
Author
|
Also @Ericson2314 claims static-pie support, it is not quite true yet: https://news.ycombinator.com/item?id=23657020 #include <stdio.h>
int main() {
printf("main: %p\n", main);
return 0;
}with import <nixpkgs> {};
stdenv.mkDerivation {
name = "env";
nativeBuildInputs = [
bashInteractive
];
buildInputs = [
glibc.static
];
}$ gcc -static-pie -o main main.c
$ gdb ./main
Reading symbols from ./main...
(gdb) r
Starting program: /tmp/tmp.kSRlP5T372/solo5/main
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7f5115c in __dcigettext ()
(gdb) bt
#0 0x00007ffff7f5115c in __dcigettext ()
#1 0x00007ffff7f502ce in __assert_fail ()
#2 0x00007ffff7f90415 in _dl_relocate_static_pie ()
#3 0x00007ffff7f4f3b8 in __libc_start_main ()
#4 0x00007ffff7f4ee1a in _start () at ../sysdeps/x86_64/start.S:120 |
Member
Author
|
My blind guess is, that it somehow breaks TLS: |
Member
Author
|
This works in an archlinux container. So it is something that breaks in our setup. |
Member
Author
|
This is what archlinux produces: This is Nixpkgs: |
Member
Author
|
Interesting enough even without the change glibc already builds |
8 tasks
This enables ALSR on static executables, which makes them harder to exploit by providing a crt suitable for static PIEs. Does this break existing binaries? Likely not. Static-pie is only used if explicitly enabled.
Member
Author
|
Ha! It works now. After compiling glibc from source I could pin-point the assertion that broke the execution. |
Mic92
commented
May 22, 2021
Mic92
commented
May 22, 2021
e8fd80d to
831abe9
Compare
2676fc1 to
8a4dcb6
Compare
1a3860b to
166948d
Compare
5 tasks
Ericson2314
reviewed
May 24, 2021
Ericson2314
approved these changes
May 24, 2021
Member
Ericson2314
left a comment
There was a problem hiding this comment.
I think something like my comment would make it easier to understand, but that aside LGTM.
Co-authored-by: John Ericson <git@JohnEricson.me>
Member
Author
|
Someone tested also macOS/clang for me. Good to go. |
Contributor
|
I think this change broke glibc on armv7l: According to https://sourceware.org/glibc/wiki/PortStatus
On Debian and Gentoo Reverting 61c74e1 (on top of 59ef808) allowed me to successfully build glibc on armv7l. |
Mic92
commented
Jul 1, 2021
| "--enable-add-ons" | ||
| "--sysconfdir=/etc" | ||
| "--enable-stackguard-randomization" | ||
| "--enable-static-pie" |
Member
Author
There was a problem hiding this comment.
Well I guess this line should be disabled on arm-legacy again than.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables ALSR on static executables, which makes them harder to
exploit by providing a crt suitable for static PIEs.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)