Skip to content

haskell.compiler.ghcHEAD: disable DWARF on non x86#123377

Merged
cdepillabout merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:fix-ghc-head
May 18, 2021
Merged

haskell.compiler.ghcHEAD: disable DWARF on non x86#123377
cdepillabout merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:fix-ghc-head

Conversation

@sternenseemann
Copy link
Copy Markdown
Member

@sternenseemann sternenseemann commented May 17, 2021

The broken build of ghcHEAD on aarch64-linux results from rts/Libdw.c
not supporting that platform. Seemingly this particular file is only
relevant for DWARF support in GHC, so we disable that on unsupported
platforms.

(untested)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
haskell.compiler.ghcHEAD: disable DWARF on non x86
f90244c 
The broken build of ghcHEAD on aarch64-linux results from rts/Libdw.c
not supporting that platform. Seemingly this particular file is only
relevant for DWARF support in GHC, so we disable that on unsupported
platforms.
@sternenseemann
Copy link
Copy Markdown
Member Author

sternenseemann commented May 17, 2021

@ofborg build haskell.compiler.ghcHEAD

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 17, 2021
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label May 17, 2021
@ofborg ofborg bot requested review from MarcWeber, kosmikus and peti May 17, 2021 15:33
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 17, 2021
@sternenseemann
haskell.compiler.ghcHEAD: bootstrap using GHC 9.0
29e029d 
They use matching LLVM versions which should alleviate some warnings.
@sternenseemann
Copy link
Copy Markdown
Member Author

sternenseemann commented May 17, 2021

@ofborg build haskell.compiler.ghcHEAD

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 17, 2021
@sternenseemann
Copy link
Copy Markdown
Member Author

sternenseemann commented May 17, 2021

Gonna merge this tomorrow if no one objects, hydra should tell us if it indeed fixes the build.

@cdepillabout
Copy link
Copy Markdown
Member

cdepillabout commented May 18, 2021

It looks like ofborg successfully built this on x86-64 linux, so I'll merge in and see what hydra thinks about this on aarch64.

Thanks for looking into this!

@cdepillabout cdepillabout merged commit c5cd6a2 into NixOS:haskell-updates May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@maralorn maralorn Awaiting requested review from maralorn

@peti peti Awaiting requested review from peti

@MarcWeber MarcWeber Awaiting requested review from MarcWeber

@kosmikus kosmikus Awaiting requested review from kosmikus

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sternenseemann @cdepillabout