Result of nixpkgs-review pr 122476 at 80286e3d run on x86_64-linux 1

@cyplo Would you mind submitting your nice patch upstream?

@SuperSandro2000 - not sure if splitting the arrays into multiple lines makes it more readable, is this more idiomatic ? Also - not sure if having -r on a separate line is equivalent to having it in one string ?

@veprbl - yeah defo, once this lands in nixos I will submit upstream - ideally with someone giving this a go on a MacOS box before, as I don't have access to any.

@cyplo The preferred way is to first have the patch upstream and then pull it down using fetchpatch in the expression. I agree with your response to the formatting comments.

@SuperSandro2000 - not sure if splitting the arrays into multiple lines makes it more readable, is this more idiomatic ? Also - not sure if having -r on a separate line is equivalent to having it in one string ?

@veprbl - yeah defo, once this lands in nixos I will submit upstream - ideally with someone giving this a go on a MacOS box before, as I don't have access to any.

It is less likely to cause merge conflicts and beginning with a line length of ~120 it should always be done to keep the lines readable on the GitHub web interface.

Also please upstream patches beforehand because the developer can give important feedback which we can't know about.

Fixing darwin build would additionally require

diff --git a/pkgs/applications/editors/mindforger/default.nix b/pkgs/applications/editors/mindforger/default.nix
index 512e0f12441..bbbdd34a9fc 100644
--- a/pkgs/applications/editors/mindforger/default.nix
+++ b/pkgs/applications/editors/mindforger/default.nix
@@ -27,6 +27,9 @@ mkDerivation rec {
   postPatch = ''
     substituteInPlace lib/src/install/installer.cpp --replace /usr "$out"
     substituteInPlace app/resources/gnome-shell/mindforger.desktop --replace /usr "$out"
+    for f in app/app.pro lib/lib.pro; do
+      substituteInPlace "$f" --replace "QMAKE_CXX = g++" ""
+    done
   '';
 
   qmakeFlags = [ "-r mindforger.pro" "CONFIG+=mfnoccache" ] ;

nice one, thank you both ! will try to contact upstream and let's see how it goes :)

the upstream did not respond - will apply suggestions here and reference the patch commit and let you know :)

@veprbl @SuperSandro2000 if you could review that would be grand
OfBorg seems stuck on the darwin build btw, not sure if related to the PR

awesome work, thank you !