Skip to content

spago: 0.20.1 -> 0.20.2#121970

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
cdepillabout:spago-0.20.2
May 7, 2021
Merged

spago: 0.20.1 -> 0.20.2#121970
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
cdepillabout:spago-0.20.2

Conversation

@cdepillabout
Copy link
Copy Markdown
Member

@cdepillabout cdepillabout commented May 7, 2021 •
edited
Loading

Motivation for this change

New version of spago was released: https://github.com/purescript/spago/releases/tag/0.20.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @f-f

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 7, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 7, 2021
@cdepillabout
Copy link
Copy Markdown
Member Author

cdepillabout commented May 7, 2021

@ofborg build spago

sternenseemann
sternenseemann approved these changes May 7, 2021
View reviewed changes
pkgs/development/tools/purescript/spago/update.sh
echo "# This has been automatically generated by the script" > "$spago_derivation_file"
echo "# ./update.sh. This should not be changed by hand." >> "$spago_derivation_file"

cabal2nix --revision "$new_version" "https://github.com/purescript/spago.git" >> "$spago_derivation_file"
Copy link
Copy Markdown
Member

@sternenseemann sternenseemann May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't need submodules we should probably switch to fetchzip and the github tag archive at some point.

Copy link
Copy Markdown
Member Author

@cdepillabout cdepillabout May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's a good point. I'll have to switch to that method at some point.

@cdepillabout cdepillabout merged commit f73c227 into NixOS:haskell-updates May 7, 2021
@cdepillabout cdepillabout deleted the spago-0.20.2 branch May 7, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cdepillabout @sternenseemann