Skip to content

haskell.compiler.ghcHEAD: 8.11.20200824 -> 9.3.20210504#121807

Merged
sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann:update-ghcHEAD
May 8, 2021
Merged

haskell.compiler.ghcHEAD: 8.11.20200824 -> 9.3.20210504#121807
sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann:update-ghcHEAD

Conversation

@sternenseemann
Copy link
Copy Markdown
Member

@sternenseemann sternenseemann commented May 5, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann sternenseemann requested review from peti and utdemir May 5, 2021 14:50
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 5, 2021
@sternenseemann sternenseemann mentioned this pull request May 5, 2021
Merged
2 tasks
@ofborg ofborg bot requested review from MarcWeber and kosmikus May 5, 2021 15:00
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 5, 2021
@vcunat
Copy link
Copy Markdown
Member

vcunat commented May 5, 2021

I'm not sure about @peti; perhaps he'll want to (eventually) remove himself from various meta.maintainers...

cdepillabout
cdepillabout approved these changes May 6, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @ggreif since he would often do the GHC updates

@sternenseemann sternenseemann merged commit b4c069d into NixOS:master May 8, 2021
@sternenseemann sternenseemann deleted the update-ghcHEAD branch May 8, 2021 11:03
@sternenseemann sternenseemann restored the update-ghcHEAD branch July 24, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

@peti peti Awaiting requested review from peti

@utdemir utdemir Awaiting requested review from utdemir

@MarcWeber MarcWeber Awaiting requested review from MarcWeber

@kosmikus kosmikus Awaiting requested review from kosmikus

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sternenseemann @vcunat @cdepillabout