Skip to content

pkgs/tests/haskell: refactor and fix shellFor test#121386

Merged
sternenseemann merged 5 commits intoNixOS:haskell-updatesfrom
sternenseemann:haskell-tests
May 1, 2021
Merged

pkgs/tests/haskell: refactor and fix shellFor test#121386
sternenseemann merged 5 commits intoNixOS:haskell-updatesfrom
sternenseemann:haskell-tests

Conversation

@sternenseemann
Copy link
Copy Markdown
Member

@sternenseemann sternenseemann commented May 1, 2021 •
edited
Loading

Motivation for this change

I want to have a set that contains all haskell related tests, so we can easily add it to the haskell-updates hydra job without having to update two lists (pkgs/tests/default.nix and the hydra job) every time we add a new test.

Also fix the shellFor test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann sternenseemann requested a review from edolstra as a code owner May 1, 2021 11:33
@github-actions github-actions bot added the 6.topic: policy discussion Discuss policies to work in and around Nixpkgs label May 1, 2021
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 1, 2021
@sternenseemann sternenseemann mentioned this pull request May 1, 2021
Merged
10 tasks
@maralorn maralorn added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 1, 2021
maralorn
maralorn approved these changes May 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@maralorn maralorn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I have run that test. It works.

@sternenseemann
Copy link
Copy Markdown
Member Author

sternenseemann commented May 1, 2021

/rebase haskell-updates

@sternenseemann @github-actions
tests.haskell*: move into tests.haskell set
a642f57 
This will make it easier to add all haskell related tests to the haskell
hydra jobset without updating a list of tests in two places.
@sternenseemann @github-actions
tests.haskell.shellFor: replace database-id-class with linear
e1a1979 
Contrary to database-id-class, linear is part of stackage and actively
maintained, so the test is less likely to fail due to version
constraint issues as it is currently.
@sternenseemann @github-actions
tests.haskell.shellFor: use writeText instead of toFile
1e3cd67
@sternenseemann @github-actions
CODEOWNERS: notify for haskell specific tests
2426db8
@sternenseemann @github-actions
labeler: tag haskell tests as topic: haskell
53de5c3
@github-actions github-actions bot changed the base branch from master to haskell-updates May 1, 2021 19:17
@github-actions github-actions bot closed this May 1, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 1, 2021

Rebased, please reopen the pull request to restart CI

@sternenseemann sternenseemann reopened this May 1, 2021
@github-actions github-actions bot removed the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 1, 2021
@sternenseemann sternenseemann merged commit 111151c into NixOS:haskell-updates May 1, 2021
@sternenseemann sternenseemann deleted the haskell-tests branch May 1, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maralorn maralorn maralorn approved these changes

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@edolstra edolstra Awaiting requested review from edolstra

Assignees

No one assigned

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sternenseemann @maralorn