Skip to content

mesa: 21.0.1 -> 21.0.2#118753

Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
primeos:mesa
Apr 7, 2021
Merged

mesa: 21.0.1 -> 21.0.2#118753
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
primeos:mesa

Conversation

@primeos
Copy link
Copy Markdown
Member

@primeos primeos commented Apr 7, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from vcunat April 7, 2021 18:44
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Apr 7, 2021
vcunat
vcunat approved these changes Apr 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, but I haven't tried running against the drivers.

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Apr 7, 2021

https://lists.freedesktop.org/archives/mesa-announce/2021-April/000625.html

@r-rmcgibbo
Copy link
Copy Markdown

r-rmcgibbo commented Apr 7, 2021

Result of nixpkgs-review pr 118753 at e3bc983 run on x86_64-linux 1

699 packages marked as broken and skipped:
  • adobe-reader
  • adoptopenjdk-hotspot-bin-13
  • adoptopenjdk-hotspot-bin-14
  • adoptopenjdk-jre-hotspot-bin-13
  • adoptopenjdk-jre-hotspot-bin-14
  • adoptopenjdk-jre-openj9-bin-13
  • adoptopenjdk-jre-openj9-bin-14
  • adoptopenjdk-openj9-bin-13
  • adoptopenjdk-openj9-bin-14
  • agdaPackages.iowa-stdlib
  • ...
1 package failed to build:
8284 packages skipped due to time constraints:
  • AusweisApp2
  • DisnixWebService
  • EmptyEpsilon
  • Fabric (python38Packages.Fabric)
  • MIDIVisualizer
  • OSCAR
  • R
  • SDL
  • SDL2_gfx
  • SDL2_image
  • ...
38 packages built successfully:
  • SDL2
  • asciidoctor
  • at-spi2-atk
  • at-spi2-core
  • atk (gnome2.atk ,gnome3.atk)
  • cairo (gnome2.cairo)
  • egl-wayland
  • epoxy
  • freeglut
  • gdk-pixbuf
  • gl2ps
  • libsoup (gnome2.libsoup)
  • pango (gnome2.pango)
  • gobject-introspection (gnome3.gobject-introspection)
  • gsettings-desktop-schemas (gnome3.gsettings-desktop-schemas)
  • libgudev (gnome3.libgudev)
  • tracker (gnome3.tracker)
  • harfbuzz
  • icesl
  • json-glib
  • lasem
  • libGL
  • libGLU (mesa_glu)
  • libass
  • libdevil
  • libinput
  • libmanette
  • libmbim
  • libnotify
  • libqrtr-glib
  • libva
  • libwacom
  • mesa
  • python38Packages.dbus-python
  • python38Packages.pycairo
  • python38Packages.pygobject3
  • softmaker-office
  • tesseract4
2 suggestions:
  • warning: unused-argument

    Unused argument: enableRadv.
    Near pkgs/development/libraries/mesa/default.nix:8:3:

      |
8 | , enableRadv ? true
  |   ^
  • warning: unnecessary-parallel-building

    Meson, CMake and qmake already set enableParallelBuilding = true by default so it is not necessary.

    Near pkgs/development/libraries/mesa/default.nix:147:3:

        |
147 |   enableParallelBuilding = true;
    |   ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

@SuperSandro2000 SuperSandro2000 merged commit b8d1e16 into NixOS:staging Apr 7, 2021
@primeos
Copy link
Copy Markdown
Member Author

primeos commented Apr 13, 2021 •
edited
Loading

My initial testing was fine and I can successfully launch applications and X11 but I just noticed that I cannot launch sway and cage anymore (Cage seems to fail due to XWayland segfaulting but for Sway I've disabled XWayland) - both of them will segfault but run fine if I revert this update (only the one commit, no other changes). This might only affect the iris driver though. I haven't seen any bug reports about this yet so it could also be Nixpkgs related. Not sure if I'll have time to investigate or if it's even worth it (vs. waiting for the next release).

Here's the output for starting Signal-Desktop via Cage:

sway[874]: glamor: No eglstream capable devices found
sway[874]: (EE)
sway[874]: (EE) Backtrace:
sway[874]: (EE) 0: Xwayland (OsSigHandler+0x25) [0x5a2925]
sway[874]: (EE) 1: /nix/store/1jn6apz0fa9h9x7rl3v6vwiymwnjznwv-glibc-2.32-40/lib/libpthread.so.0 (funlockfile+0x50) [0x7f4f4f14e700]
sway[874]: (EE) 2: /run/opengl-driver/lib/dri/iris_dri.so (driCreateContextAttribs+0x56) [0x7f4f4d774386]
sway[874]: (EE) 3: /run/opengl-driver/lib/dri/iris_dri.so (driCreateNewContext+0x2e) [0x7f4f4d77482e]
sway[874]: (EE) 4: /nix/store/mijk8fqjp82xnh8w8b0s5jsxn10386qq-mesa-21.0.2-drivers/lib/libEGL_mesa.so.0 (dri2_setup_extensions+0x16) [0x7f4f4e8ce0c6]
sway[874]: (EE) 5: /nix/store/mijk8fqjp82xnh8w8b0s5jsxn10386qq-mesa-21.0.2-drivers/lib/libEGL_mesa.so.0 (dri2_initialize_drm+0x236) [0x7f4f4e8d3ca6]
sway[874]: (EE) 6: /nix/store/mijk8fqjp82xnh8w8b0s5jsxn10386qq-mesa-21.0.2-drivers/lib/libEGL_mesa.so.0 (dri2_initialize+0x88) [0x7f4f4e8cc258]
sway[874]: (EE) 7: /nix/store/mijk8fqjp82xnh8w8b0s5jsxn10386qq-mesa-21.0.2-drivers/lib/libEGL_mesa.so.0 (eglInitialize+0x1dc) [0x7f4f4e8c4b0c]
sway[874]: (EE) 8: Xwayland (xwl_glamor_gbm_init_egl+0xb9) [0x44c439]
sway[874]: (EE) 9: Xwayland (xwl_glamor_init+0x32) [0x44bc72]
sway[874]: (EE) 10: Xwayland (xwl_screen_init+0x6b9) [0x444799]
sway[874]: (EE) 11: Xwayland (AddScreen+0xd7) [0x56cef7]
sway[874]: (EE) 12: Xwayland (InitOutput+0xf5) [0x444965]
sway[874]: (EE) 13: Xwayland (dix_main+0x18c) [0x570aac]
sway[874]: (EE) 14: /nix/store/1jn6apz0fa9h9x7rl3v6vwiymwnjznwv-glibc-2.32-40/lib/libc.so.6 (__libc_start_main+0xed) [0x7f4f4efa1ded]
sway[874]: (EE) 15: Xwayland (_start+0x2a) [0x44239a]
sway[874]: (EE)
sway[874]: (EE) Segmentation fault at address 0xa0
sway[874]: (EE)
sway[874]: Fatal server error:
sway[874]: (EE) Caught signal 11 (Segmentation fault). Server aborting
sway[874]: (EE)
systemd-coredump[885]: Process 874 (Xwayland) of user 1001 dumped core.
sway[839]: 00:00:01.905 [ERROR] [xwayland/server.c:234] Xwayland startup failed, not setting up xwm
systemd-coredump[910]: Process 848 (signal-desktop) of user 1001 dumped core.
systemd-coredump[917]: Process 839 (.cage-wrapped) of user 1001 dumped core.

@vcunat do you mind if I just revert this commit for now or should we wait and see if we find a solution before this lands in staging-next/master?

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Apr 13, 2021

OK, it sounds best to revert until we know more.

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Apr 13, 2021 •
edited
Loading

BTW, as of current staging, mesa updates aren't large rebuilds anymore... so they won't need to go through staging, at least after the current staging merges :-)

primeos added a commit that referenced this pull request Apr 13, 2021
@primeos
Revert "mesa: 21.0.1 -> 21.0.2"
25ae1fd 
This reverts commit e3bc983.

It caused segmentation faults for at least Sway and XWayland with the
iris driver, see [0]. The cause and impact of this regression is still
unknown but let's revert it until we know more.

[0]: #118753 (comment)
@primeos
Copy link
Copy Markdown
Member Author

primeos commented Apr 13, 2021

Thanks for your fast reply, I've just reverted it in 25ae1fd.

BTW, as of current staging, mesa updates aren't large rebuilds anymore...

Wow, nice :) I didn't expect that the amount of rebuilds would drop that significantly, that's awesome!

@vcunat
Copy link
Copy Markdown
Member

vcunat commented Apr 13, 2021 

$ ./maintainers/scripts/rebuild-amount.sh HEAD^ HEAD
Estimating rebuild amount by counting changed Hydra jobs.
   1469 x86_64-darwin
    868 x86_64-linux

@primeos primeos mentioned this pull request Apr 13, 2021
Closed
10 tasks
@primeos primeos mentioned this pull request Apr 23, 2021
Merged
10 tasks
primeos added a commit to primeos/nixpkgs that referenced this pull request May 20, 2021
@primeos
mesa: 21.0.1 -> 21.0.3
7106fca 
Note: The update to Mesa 21.0.2 was reverted (25ae1fd) because it
caused major issues with Sway (segfault on startup [0]).
This is still the case and might affect all packages that directly
depend on "mesa" (for libgbm or libglapi) but it only causes issues when
the package depends on a "mesa" version that differs from "mesa.drivers"
used for "/run/opengl-driver/". I've noticed this while testing Mesa
updates with the NixOS option "hardware.opengl.package" (as usual)
instead of rebuilding my whole system (which would work). Unfortunately
this can/will likely also cause issues when mixing different channels,
using Flakes/Overlays, etc.

The cause of this should be similar to [1] ("mesa" updates now cause the
same issues that "glibc" updates already do, maybe triggered by certain
Mesa changes) and some additional discussions is in [2],[3].

Note: Don't backport this to NixOS 21.05, at least not without careful
consideration.

[0]: NixOS#118753 (comment)
[1]: NixOS#95808
[2]: NixOS#120325
[3]: NixOS#119558
@primeos primeos mentioned this pull request May 24, 2021
Merged
10 tasks
vcunat pushed a commit that referenced this pull request Jul 25, 2021
@primeos
mesa: 21.0.1 -> 21.0.3
e0e0ca9 
Note: The update to Mesa 21.0.2 was reverted (25ae1fd) because it
caused major issues with Sway (segfault on startup [0]).
This is still the case and might affect all packages that directly
depend on "mesa" (for libgbm or libglapi) but it only causes issues when
the package depends on a "mesa" version that differs from "mesa.drivers"
used for "/run/opengl-driver/". I've noticed this while testing Mesa
updates with the NixOS option "hardware.opengl.package" (as usual)
instead of rebuilding my whole system (which would work). Unfortunately
this can/will likely also cause issues when mixing different channels,
using Flakes/Overlays, etc.

The cause of this should be similar to [1] ("mesa" updates now cause the
same issues that "glibc" updates already do, maybe triggered by certain
Mesa changes) and some additional discussions is in [2],[3].

Note: Don't backport this to NixOS 21.05, at least not without careful
consideration.

[0]: #118753 (comment)
[1]: #95808
[2]: #120325
[3]: #119558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@primeos @vcunat @r-rmcgibbo @SuperSandro2000