Skip to content

.github/workflows/labels.yml: label PRs#113077

Merged
cole-h merged 2 commits intoNixOS:masterfrom
zowoq:actions-labeler
Mar 21, 2021
Merged

.github/workflows/labels.yml: label PRs#113077
cole-h merged 2 commits intoNixOS:masterfrom
zowoq:actions-labeler

Conversation

@zowoq
Copy link
Copy Markdown
Contributor

@zowoq zowoq commented Feb 14, 2021 •
edited
Loading

Motivation for this change
  • Easier to update when it's in the same repo.
  • Labels will be accurate, e.g. docker won't be labelled with documentation.
  • Doesn't require a redeploy of ofborg to pick up changes.

This will need to be merged after the labels are removed from config.public.json in ofborg and it is redeployed, I'll open a PR to do that if this one is accepted.

This will only affect labels that are listed here so the behaviour of manual and other ofborg labels (e.g. rebuilds, security, etc) will remain the same as it is currently.

@zowoq zowoq requested a review from Mic92 as a code owner February 14, 2021 03:36
@zowoq zowoq marked this pull request as draft February 14, 2021 03:36
@ofborg ofborg bot added 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 14, 2021
grahamc
grahamc reviewed Feb 14, 2021
View reviewed changes
.github/workflows/labels.yml Outdated
Copy link
Copy Markdown
Member

@grahamc grahamc Feb 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean it'll only labels PRs which are made from branches within the NixOS organization?

Copy link
Copy Markdown
Contributor Author

@zowoq zowoq Feb 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it just blocks the action from running in PRs in peoples forks.

We have the same thing in editorconfig, etc

nixpkgs/.github/workflows/editorconfig.yml

Line 11 in e0c0505

if: github.repository_owner == 'NixOS'

marsam
marsam reviewed Feb 15, 2021
View reviewed changes
@zowoq
Copy link
Copy Markdown
Contributor Author

zowoq commented Feb 20, 2021 •
edited
Loading

Forgot to mention that this will need to be backported and future changes to the list of labels would also need to be backported if we want the labels kept in sync for the release branch. I don't think that would be too much hassle?

We could add an action for keeping .github/** synced to the release branch, might be useful for other things in that directory like the PR templates? Simplest option would probably be just checking the diff between the branches and posting a comment.

This was referenced Feb 25, 2021
Open
Merged
@zowoq
Copy link
Copy Markdown
Contributor Author

zowoq commented Mar 3, 2021

Opened a PR to remove these from ofborg: NixOS/ofborg#553

@zowoq zowoq added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Mar 3, 2021
@zowoq zowoq marked this pull request as ready for review March 3, 2021 21:18
@zowoq
Copy link
Copy Markdown
Contributor Author

zowoq commented Mar 18, 2021

@cole-h @grahamc Can we move forward with this and NixOS/ofborg#553?

@cole-h
Copy link
Copy Markdown
Member

cole-h commented Mar 18, 2021

Sure. However, I won't have time to monitor an ofborg deploy until this weekend (and after work).

/me sets a reminder.

@cole-h cole-h merged commit 13e762e into NixOS:master Mar 21, 2021
@cole-h
Copy link
Copy Markdown
Member

cole-h commented Mar 21, 2021

Deployed, and it works! Thanks @zowoq :)

(Test PR: #117084)

@zowoq zowoq deleted the actions-labeler branch March 21, 2021 04:37
@zowoq zowoq added 8.has: port to stable This PR already has a backport to the stable release. and removed 2.status: wait-for-upstream Waiting for upstream fix (or their other action). labels Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

2 more reviewers

@marsam marsam marsam left review comments

@grahamc grahamc grahamc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zowoq @cole-h @marsam @grahamc