Skip to content

nixos/vsftpd: add userlist type#111441

Closed
Scriptkiddi wants to merge 2 commits intoNixOS:masterfrom
helsinki-systems:vsftpd
Closed

nixos/vsftpd: add userlist type#111441
Scriptkiddi wants to merge 2 commits intoNixOS:masterfrom
helsinki-systems:vsftpd

Conversation

@Scriptkiddi
Copy link
Copy Markdown
Contributor

@Scriptkiddi Scriptkiddi commented Jan 31, 2021

Motivation for this change

#76184

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yorickvP
Copy link
Copy Markdown
Contributor

yorickvP commented Jan 31, 2021

This individual change is fine, but userlistFile should be filled in from this option as something stronger than a default, to prevent careless overriding. Something like
services.vsftpd.userlistFile = lib.mkIf (cfg.userlist != []) (pkgs.writeText "userlist" (concatMapStrings (x: "${x}\n") cfg.userlist);?

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 31, 2021
@Scriptkiddi
Copy link
Copy Markdown
Contributor Author

Scriptkiddi commented Feb 5, 2021

@yorickvP like this?

@Scriptkiddi Scriptkiddi requested a review from picnoir February 5, 2021 14:41
cole-h
cole-h reviewed Feb 6, 2021
View reviewed changes
yorickvP
yorickvP requested changes Apr 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@yorickvP yorickvP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the assertion won't work, since we override userListFile in this package if someone sets userList. However, the check will still happen without the assertion since you wouldn't be able to merge in another userListFile.

@ofborg ofborg bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Oct 15, 2021
@dasJ dasJ mentioned this pull request Nov 4, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cole-h cole-h cole-h left review comments

@yorickvP yorickvP yorickvP requested changes

@picnoir picnoir Awaiting requested review from picnoir

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Scriptkiddi @yorickvP @cole-h