Skip to content

nixos treewide: Fix references to linux-kernel.target#110803

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314:fix-nixos-misc-linux-config
Jan 25, 2021
Merged

nixos treewide: Fix references to linux-kernel.target#110803
Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314:fix-nixos-misc-linux-config

Conversation

@Ericson2314
Copy link
Copy Markdown
Member

@Ericson2314 Ericson2314 commented Jan 25, 2021

Motivation for this change

Thanks @ajs124 in #110544 (comment) for catching this. According to:

git grep 'inherit.*Platform.*platform'
git grep ' linux-kernel'

We now don't have any remaining problems of this sort, thankfully.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ericson2314
nixos treewide: Fix references to linux-kernel.target
63b02e5 
Thanks @ajs124 in
NixOS#110544 (comment) for
catching this. According to:

    git grep 'inherit.*Platform.*platform'
    git grep ' linux-kernel'

We now don't have any remaining problems of this sort, thankfully.
@Ericson2314 Ericson2314 mentioned this pull request Jan 25, 2021
Merged
10 tasks
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 25, 2021
ajs124
ajs124 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ajs124 ajs124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really an expert on this part of nixpkgs, I was just getting some annoying emails from my hydra and tracked down what happened.

These changes look alright to me.

Thanks for your work on this infrastructure @Ericson2314

@Ericson2314 Ericson2314 merged commit e34a53c into NixOS:master Jan 25, 2021
@Ericson2314 Ericson2314 deleted the fix-nixos-misc-linux-config branch January 25, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajs124 ajs124 ajs124 approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ericson2314 @ajs124