Skip to content

yarn2nix: updates from nix-community/yarn2nix#108138

Merged
Lassulus merged 3 commits intoNixOS:masterfrom
Lassulus:yarn2nix_move
May 20, 2021
Merged

yarn2nix: updates from nix-community/yarn2nix#108138
Lassulus merged 3 commits intoNixOS:masterfrom
Lassulus:yarn2nix_move

Conversation

@Lassulus
Copy link
Copy Markdown
Member

@Lassulus Lassulus commented Jan 1, 2021

I have not tested this, but code looked fine to me.

We still need to close down the old repo and notify everybody that development/contributions should now happen here.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 1, 2021
@SuperSandro2000
Copy link
Copy Markdown
Member

The second commit is not prefetched with yarn2nix.

@flokli
Copy link
Copy Markdown
Member

flokli commented Jan 2, 2021

@Lassulus how can this be tested?

@Lassulus
Copy link
Copy Markdown
Member Author

@flokli just using it? I don't know. but if the nix-community/yarn2nix works for you I don't see why this shouldn't. I just fixed it because I wanted to package workadventure and it worked fine for that usecase.

@flokli
Copy link
Copy Markdown
Member

flokli commented Apr 29, 2021

alright, SGTM.

@Lassulus Lassulus merged commit c03bb4d into NixOS:master May 20, 2021
@Profpatsch
Copy link
Copy Markdown
Member

I’m trying to link to this from my yarn2nix’s Readme, but it look like there is no readme, no manual section, nothing documenting this tool. What do?

@Profpatsch
Copy link
Copy Markdown
Member

Like, the code is here but no readme: https://github.com/NixOS/nixpkgs/tree/master/pkgs/development/tools/yarn2nix-moretea/yarn2nix

And grepping through the nixpkgs manual there is no mention of yarn2nix I can see.

@GuillaumeDesforges
Copy link
Copy Markdown
Contributor

For anyone falling there in the future, check out the manual https://nixos.org/manual/nixpkgs/stable/#javascript-yarn2nix

@sielicki
Copy link
Copy Markdown
Contributor

sielicki commented Feb 9, 2023

Hate to be that guy but the old repo was licensed GPL3, so what's the license under nixpkgs for this?

@Lassulus
Copy link
Copy Markdown
Member Author

I guess still GPL3? but I dunno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants