tensorflow1: disable sysctl.h in hwloc#107944
Merged
matthewbauer merged 1 commit intoNixOS:masterfrom Jan 1, 2021
Merged
Conversation
We need to override tensorflow's hwloc configuration, since it forces sysctl.h usage which is removed since glibc 2.31. This does not appear to effect tensorflow2. See also tensorflow/tensorflow#45861 Fixes NixOS#104801
Emantor
approved these changes
Dec 31, 2020
Member
Emantor
left a comment
There was a problem hiding this comment.
Makes sense to me, upstream does not seem to support 1.x builds any more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to override tensorflow's hwloc configuration, since it forces
sysctl.h usage which is removed since glibc 2.31. This does not appear
to effect tensorflow2.
See also tensorflow/tensorflow#45861
Fixes #104801
Things done